Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if gcc version is lower than 4.8 #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamatan
Copy link

The -Og parameter was introduced in in gcc 4.8. When running make with older versions of gcc (as the default one in OSX/XCode), the following error message appears:

error: invalid integral value 'g' in '-Og'

The following PR shows an error message if the gcc version is older than 4.8. I've chosen not to exit the make process, just in case this logic would fail in some edge case.

See also:

@dvirsky
Copy link
Contributor

dvirsky commented Feb 24, 2017

Actually you can remove -Og completely, but thanks for noticing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants