Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation with V8 version >= 11.9. #58

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Fix compilation with V8 version >= 11.9. #58

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
624fdf8
Fix compilation with V8 version >= 11.9.
MeirShpilraien Sep 10, 2023
9868a11
Fix comment typo
MeirShpilraien Sep 10, 2023
25d0a9f
Review fixes
MeirShpilraien Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion v8_c_api/src/v8_c_api.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1299,7 +1299,7 @@ void v8_ObjectSetInternalField(v8_local_object *obj, size_t index, v8_local_valu
}

v8_local_value* v8_ObjectGetInternalField(v8_local_object *obj, size_t index) {
v8::Local<v8::Value> val = obj->obj->GetInternalField(index);
v8::Local<v8::Value> val = obj->obj->GetInternalField(index).As<v8::Value>();
v8_local_value *res = (v8_local_value*) V8_ALLOC(sizeof(*res));
res = new (res) v8_local_value(val);
return res;
Expand Down