Remove some unused methods of the Inspector.

RedisGears · Aug 29, 2023 · f85e92b · f85e92b
1 parent e53bdd8
commit f85e92b
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 70 deletions.
diff --git a/src/v8/inspector/mod.rs b/src/v8/inspector/mod.rs
@@ -62,16 +62,6 @@ impl RawInspector {
         Self { raw }
     }
 
-    /// Sets a new (possibly another) [crate::v8::isolate::V8Isolate].
-    pub fn set_isolate(&self, raw_isolate: NonNull<v8_isolate>) {
-        unsafe { crate::v8_c_raw::bindings::v8_InspectorSetIsolate(self.raw, raw_isolate.as_ptr()) }
-    }
-
-    /// Sets a new context.
-    pub fn set_context(&self, raw_context: NonNull<v8_context_ref>) {
-        unsafe { crate::v8_c_raw::bindings::v8_InspectorSetContext(self.raw, raw_context.as_ptr()) }
-    }
-
     /// Returns the isolate this inspector is bound to. The isolate
     /// returned won't be released automatically.
     pub fn get_isolate(&self) -> V8Isolate {

diff --git a/src/v8/inspector/server.rs b/src/v8/inspector/server.rs
@@ -678,11 +678,6 @@ impl DebuggerSession {
             }
         }
     }
-
-    /// Sets another context for the inspector.
-    pub fn set_context(&self, context: NonNull<v8_context_ref>) {
-        self.inspector.set_context(context);
-    }
 }
 
 #[cfg(test)]

diff --git a/v8_c_api/src/v8_c_api.cpp b/v8_c_api/src/v8_c_api.cpp
@@ -154,16 +154,13 @@ class v8_inspector_client_wrapper final: public v8_inspector::V8InspectorClient
 public:
   explicit v8_inspector_client_wrapper(
 	v8::Platform *platform,
-    v8::Isolate *isolate,
 	const v8::Local<v8::Context> &context,
 	const InspectorOnResponseCallback &onResponse = {},
 	const InspectorOnWaitFrontendMessageOnPauseCallback &onWaitFrontendMessageOnPause = {}
   );
 
   v8::Local<v8::Context> getContext();
-  void setContext(const v8::Local<v8::Context> &context);
   v8::Isolate* getIsolate();
-  void setIsolate(v8::Isolate *isolate);
   void setOnResponseCallback(const InspectorOnResponseCallback &callback);
   void setOnWaitFrontendMessageOnPauseCallback(const InspectorOnWaitFrontendMessageOnPauseCallback &callback);
 
@@ -174,9 +171,6 @@ class v8_inspector_client_wrapper final: public v8_inspector::V8InspectorClient
   void schedulePauseOnNextStatement(const v8_inspector::StringView &reason);
   void waitFrontendMessageOnPause();
 
-  // Can we return `v8::Local<v8::Context>` from `v8::Context *` ?
-//   v8::Local<v8::Context> ensureDefaultContextInGroup(const int contextGroupId) override;
-
 private:
   static const int kContextGroupId = 1;
   v8::Platform* platform_;
@@ -192,13 +186,11 @@ class v8_inspector_client_wrapper final: public v8_inspector::V8InspectorClient
 
 v8_inspector_client_wrapper::v8_inspector_client_wrapper(
 	v8::Platform *platform,
-	v8::Isolate *isolate,
 	const v8::Local<v8::Context> &context,
 	const InspectorOnResponseCallback &onResponse,
 	const InspectorOnWaitFrontendMessageOnPauseCallback &onWaitFrontendMessageOnPause
 ) :
     platform_(platform),
-	// isolate_(isolate),
 	context_(context),
 	onWaitFrontendMessageOnPause_(onWaitFrontendMessageOnPause)
 {
@@ -222,23 +214,6 @@ v8::Local<v8::Context> v8_inspector_client_wrapper::getContext() {
 	return context_;
 }
 
-void v8_inspector_client_wrapper::setContext(const v8::Local<v8::Context> &context) {
-	// context_ = context;
-
-    // // session_ = inspector_->connect(kContextGroupId, channel_.get(), v8_inspector::StringView(), v8_inspector::V8Inspector::kFullyTrusted);
-    // context->SetAlignedPointerInEmbedderData(DEBUGGER_INDEX, this);
-    // v8_inspector::StringView contextName = convertToStringView("inspector");
-    // inspector_->contextCreated(v8_inspector::V8ContextInfo(context, kContextGroupId, contextName));
-	// schedulePauseOnNextStatement(convertToStringView("Context change."));
-}
-
-void v8_inspector_client_wrapper::setIsolate(v8::Isolate *isolate) {
-	// isolate_ = isolate;
-	// channel_->setIsolate(isolate_);
-    // session_ = inspector_->connect(kContextGroupId, channel_.get(), v8_inspector::StringView(), v8_inspector::V8Inspector::kFullyTrusted);
-	// setContext(isolate_->GetCurrentContext());
-}
-
 void v8_inspector_client_wrapper::setOnResponseCallback(const InspectorOnResponseCallback &callback) {
 	channel_->setOnResponseCallback(callback);
 }
@@ -409,7 +384,6 @@ struct v8_local_array_buff {
 };
 
 v8_inspector_c_wrapper* v8_InspectorCreate(
-	v8_isolate *isolate,
 	v8_context_ref *context_ref,
 	v8_InspectorOnResponseCallback onResponse,
 	void *onResponseUserData,
@@ -423,12 +397,10 @@ v8_inspector_c_wrapper* v8_InspectorCreate(
 		return onWaitFrontendMessageOnPause(inspector, onWaitUserData);
 	};
 	auto platform = GLOBAL_PLATFORM;
-	auto v8_isolate = reinterpret_cast<v8::Isolate *>(isolate);
 	auto context = context_ref->context;
 	return reinterpret_cast<v8_inspector_c_wrapper *>(
 		new v8_inspector_client_wrapper(
 			platform,
-			v8_isolate,
 			context,
 			onResponseWrapper,
 			onWaitFrontendMessageOnPauseWrapper
@@ -489,14 +461,6 @@ void v8_InspectorSetOnWaitFrontendMessageOnPauseCallback(
 	reinterpret_cast<v8_inspector_client_wrapper *>(inspector)->setOnWaitFrontendMessageOnPauseCallback(onWaitFrontendMessageOnPauseWrapper);
 }
 
-void v8_InspectorSetIsolate(
-	v8_inspector_c_wrapper *inspector,
-	v8_isolate *isolate
-) {
-	reinterpret_cast<v8_inspector_client_wrapper *>(inspector)
-		->setIsolate(reinterpret_cast<v8::Isolate *>(isolate));
-}
-
 v8_isolate* v8_InspectorGetIsolate(
 	v8_inspector_c_wrapper *inspector
 ) {
@@ -511,12 +475,6 @@ v8_context_ref* v8_InspectorGetContext(
 		reinterpret_cast<v8_inspector_client_wrapper *>(inspector)->getContext());
 }
 
-void v8_InspectorSetContext(
-	v8_inspector_c_wrapper *inspector,
-	v8_context_ref *context
-) {
-	reinterpret_cast<v8_inspector_client_wrapper *>(inspector)->setContext(context->context);
-}
 
 void get_v8_string_value(
 	v8_local_string *v8_string,

diff --git a/v8_c_api/src/v8_c_api.h b/v8_c_api/src/v8_c_api.h
@@ -132,9 +132,8 @@ typedef void (*v8_InspectorOnResponseCallback)(const char *string, void *userdat
 typedef int (*v8_InspectorOnWaitFrontendMessageOnPause)(v8_inspector_c_wrapper *inspector,  void *userdata);
 
 /** Creates a debugging inspector for the global platform and the given
-isolate. The callbacks are optional. */
+context. The callbacks are optional. */
 v8_inspector_c_wrapper* v8_InspectorCreate(
-	v8_isolate *isolate,
 	v8_context_ref *context_ref,
 	v8_InspectorOnResponseCallback onResponse,
 	void *onResponseUserData,
@@ -176,26 +175,16 @@ void v8_InspectorSetOnWaitFrontendMessageOnPauseCallback(
 	void *onWaitUserData
 );
 
-/** Sets the V8Isolate for the inspector. */
-void v8_InspectorSetIsolate(
-	v8_inspector_c_wrapper *inspector,
-	v8_isolate *isolate
-);
-
 /** Returns the V8Isolate the passed inspector is bound to. */
 v8_isolate* v8_InspectorGetIsolate(
 	v8_inspector_c_wrapper *inspector
 );
 
+/** Returns the V8ContextScope the passed inspector is bound to. */
 v8_context_ref* v8_InspectorGetContext(
 	v8_inspector_c_wrapper *inspector
 );
 
-void v8_InspectorSetContext(
-	v8_inspector_c_wrapper *inspector,
-	v8_context_ref *context
-);
-
 typedef void (*v8_StringToUtf8StringCallback)(
 	void *userdata,
 	const char *data,