Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update storage-benchmark #88

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update storage-benchmark #88

wants to merge 8 commits into from

Conversation

jgkootstra
Copy link

  • provide another way to round-down $RAMGB
  • alternative way to install fio package

@jgkootstra
Update storage-benchmark
6b3a5a3 
* provide another way to round-down $RAMGB
* alternative way to install fio package
@jgkootstra
Copy link
Author

The changes have been tested on RHEL 8 with Satellite 6.14

@jgkootstra
Update storage-benchmark
173955f 
add -y to foreman-maintain package install
pablomh
pablomh reviewed Mar 21, 2024
View reviewed changes
storage-benchmark Show resolved Hide resolved
storage-benchmark Outdated Show resolved Hide resolved
jgkootstra
jgkootstra commented Mar 25, 2024
View reviewed changes
Copy link
Author

@jgkootstra jgkootstra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may drop my branch in favor of your suggestions.

storage-benchmark Outdated Show resolved Hide resolved
pablomh added a commit that referenced this pull request Mar 26, 2024
@pablomh
fix(storage-benchmark): Fix RAMGB calculation
fdff1e6 
The previous calculation not always resulted in an integer, which wasn't what it was expected, and failed with some locales.

- Fixes: #80

- Based on input from #82 and #88.
@pablomh
Copy link
Collaborator

pablomh commented Mar 26, 2024

Hopefully fdff1e6 will address this issue.

Please, create a new issue if it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablomh pablomh pablomh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgkootstra @pablomh