Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible layering for subscription rules #43

Merged
merged 40 commits into from
Jan 23, 2019
Merged

Possible layering for subscription rules #43

merged 40 commits into from
Jan 23, 2019

Conversation

mossicrue
Copy link
Contributor

No description provided.

mossicrue and others added 30 commits October 26, 2018 10:30
@mossicrue
Upload of a possibile solution for issue RedHatSatellite#5 RedHatSate…
7194ba8 
…llite#17 RedHatSatellite#20 RedHatSatellite#21 RedHatSatellite#22
@evgeni
make the api object global
2bc4713
@evgeni
always use the host_subscriptions api
9057771 
we don't need to support Katello 2.x anymore
@evgeni
drop support for old :systems api endpoint
8b9248c
@evgeni
drop registered_by support
bb21b1a
@evgeni
move fetching of results into a helper function
a91d2eb
@evgeni
page is not needed anymore here
a53c244
@mossicrue
update code as request by Evgeni in RedHatSatellite#26
d04c4d8
@mossicrue
update code as request by Evgeni in RedHatSatellite#26, added a possi…
10733de 
…ble solution for RedHatSatellite#29
@mossicrue
Upload of a possibile solution for issue RedHatSatellite#5 RedHatSate…
91ae83b 
…llite#17 RedHatSatellite#20 RedHatSatellite#21 RedHatSatellite#22
@mossicrue
update code as request by Evgeni in RedHatSatellite#26
e6a24d3
@mossicrue
update code as request by Evgeni in RedHatSatellite#26, added a possi…
f535e55 
…ble solution for RedHatSatellite#29
@mossicrue
Merge branch 'master' of https://github.com/mossicrue/katello-attach-…
584a7a8 
…subscription
@mossicrue
Update code as requested by evgeni on 11/30
888c865
@mossicrue
Updated code as requested by Evgeni on 12/03
9d653c6
@mossicrue
Fixed output string for subscription report
96042f3
@mossicrue
Merge branch 'master' of https://github.com/RedHatSatellite/katello-a…
e356773 
…ttach-subscription
@mossicrue
possible solution for fact matcher
d71d703
@mossicrue
Merge remote-tracking branch 'upstream/master'
dd3d38b
@mossicrue
Revert "possible solution for fact matcher"
212a60b 
This reverts commit d71d703.
@mossicrue
Merge remote-tracking branch 'upstream/master'
f932a7a
@mossicrue
fixed and clean some of some code after test, add facter test for mul…
b7e8bce 
…tiple facts
@mossicrue
fixed gathering host type with fact_analyzer
6a08da7
@mossicrue
Merge branch 'master' into master
99e4dcf
@mossicrue
update code as requested by Evgeni
d69d61a
@mossicrue
Merge branch 'master' of https://github.com/mossicrue/katello-attach-…
99fcae2 
…subscription
@mossicrue
Added possible layering for sub
93f0959
@mossicrue
Fixed some error for sub_layer and merge.subs utils function
d7e8262
@mossicrue
Merge branch 'master' into sub_merger_test
8eb24fd
@mossicrue
Merge branch 'master' into sub_merger_test
be82327
evgeni
evgeni reviewed Jan 18, 2019
View reviewed changes
katello-attach-subscription Outdated Show resolved Hide resolved
evgeni
evgeni reviewed Jan 18, 2019
View reviewed changes
katello-attach-subscription Outdated Show resolved Hide resolved
evgeni
evgeni requested changes Jan 18, 2019
View reviewed changes
lib/katello_attach_subscription/utils.rb Outdated Show resolved Hide resolved
test/sub_merger_test.rb Outdated Show resolved Hide resolved
test/sub_merger_test.rb Show resolved Hide resolved
test/sub_merger_test.rb Outdated Show resolved Hide resolved
evgeni
evgeni reviewed Jan 21, 2019
View reviewed changes
test/sub_merger_test.rb Outdated Show resolved Hide resolved
evgeni
evgeni reviewed Jan 21, 2019
View reviewed changes
test/sub_merger_test.rb Outdated Show resolved Hide resolved
evgeni
evgeni reviewed Jan 21, 2019
View reviewed changes
test/sub_merger_test.rb Outdated Show resolved Hide resolved
@evgeni
Copy link
Member

evgeni commented Jan 21, 2019 •
edited
Loading

after applying my test-change suggestions, the following failures remain (no matter which merge_subs implementation`):

  1) Failure:
SubMergerTest#test_keep_parse [/home/egolov/Devel/katello-attach-subscription/test/sub_merger_test.rb:137]:
--- expected
+++ actual
@@ -1 +1 @@
-{"rhel"=>["b1a5d251fa4fe598cb947ffc42b9cbed", "1337d38747e659ed836548ae6cda7cc2"], "smartmanagement"=>["f180623caa42379bc4518d06c9c9be05"]}
+{"rhel"=>["bb98d4e9c281b175ea84c517b59308ea"], "smartmanagement"=>["af03af10d57b7b17f26a0130562d6b6e"]}


  2) Failure:
SubMergerTest#test_merge_parse [/home/egolov/Devel/katello-attach-subscription/test/sub_merger_test.rb:131]:
--- expected
+++ actual
@@ -1 +1 @@
-{"rhel"=>["b1a5d251fa4fe598cb947ffc42b9cbed", "1337d38747e659ed836548ae6cda7cc2"], "smartmanagement"=>["f180623caa42379bc4518d06c9c9be05"], "els"=>["523af537946b79c4f8369ed39ba78605"]}
+{"rhel"=>["bb98d4e9c281b175ea84c517b59308ea"], "smartmanagement"=>["af03af10d57b7b17f26a0130562d6b6e"]}

evgeni
evgeni reviewed Jan 23, 2019
View reviewed changes
test/test_helper.rb Outdated Show resolved Hide resolved
@evgeni evgeni merged commit 8b5fc9e into RedHatSatellite:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mossicrue @evgeni