-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add initial Redfish unit tests #398
Draft
matejart
wants to merge
7
commits into
RedHatQE:master
Choose a base branch
from
xlab-si:redfish-unittests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Aug 28, 2019
-
Added unit tests for Redfish system. These unit tests employ `unittest.mock`, which is a Python 3 feature only.
Configuration menu - View commit details
-
Copy full SHA for 8876b9c - Browse repository at this point
Copy the full SHA 8876b9cView commit details -
Add redfish wrapanapi properties
This adds `machine_type` and `product_name` properties to `RedfishServer`. Related PR: * ManageIQ/manageiq-providers-redfish#83
Configuration menu - View commit details
-
Copy full SHA for bde2c7a - Browse repository at this point
Copy the full SHA bde2c7aView commit details -
We address Python 3's `Exception` not having `message` anymore.
Configuration menu - View commit details
-
Copy full SHA for 3c025a9 - Browse repository at this point
Copy the full SHA 3c025a9View commit details -
Add travis steps to remove Python 3+ tests
The Redfish tests are Python 3 only. With this change we remove the tests if running in anything less than Python 3.6.
Configuration menu - View commit details
-
Copy full SHA for 8261821 - Browse repository at this point
Copy the full SHA 8261821View commit details
Commits on Aug 29, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f2694f9 - Browse repository at this point
Copy the full SHA f2694f9View commit details
Commits on Sep 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 1537347 - Browse repository at this point
Copy the full SHA 1537347View commit details
Commits on Sep 5, 2019
-
Convert redfish tests to pytest
This commit replaces the use of unittest with the constructs from pytest. We started off using unittest, but then we'd introduce parametrization, which wouldn't work because the mix with unit test caused parametrization to get lost. Now we use mainly the equivalent pytest constructs.
Configuration menu - View commit details
-
Copy full SHA for a97bcc1 - Browse repository at this point
Copy the full SHA a97bcc1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.