Refactoring of the project as part of a computer science course #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anya-x
changed the title
anya-x
changed the title
… you use isInstanceOf right after, null is not an instance of object and merging two ifs using the operator && to improve readability
mondain
reviewed
Apr 18, 2023
| @@ -319,7 +318,7 @@ public IScopeHandler lookupScopeHandler(String contextPath) { | |||
| String scopeHandlerName = getMappingStrategy().mapScopeHandlerName(contextPath); | |||
| // Get bean from bean factory | |||
| Object bean = applicationContext.getBean(scopeHandlerName); | |||
| if (bean != null && bean instanceof IScopeHandler) { | |||
| if (bean instanceof IScopeHandler) { | |||
There was a problem hiding this comment.
Ensure that getBean cannot return a null
mondain
requested changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Changes proposed in this pull request: