Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Inject prebuilt module-info.class for Module support #7333

Closed
wants to merge 3 commits into from

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Sep 6, 2021

If I understand correctly, all we need is a compiled module-info.class in the META-INF/versions/9 directory.

So instead of doing compiler tricks, I took #7332, generated the jar, extracted the module-info.class, then put the class file into the resources directory as is.

Also the bnd plugin needed to suppress the misplaces class file error.

Replaces #7332
Replaces #7241
Resolves #7240

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #7333 (d9cf03c) into 3.x (ce45fc2) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7333      +/-   ##
============================================
- Coverage     99.55%   99.51%   -0.05%     
- Complexity     6781     6782       +1     
============================================
  Files           751      751              
  Lines         47482    47482              
  Branches       6378     6378              
============================================
- Hits          47271    47252      -19     
- Misses           94      106      +12     
- Partials        117      124       +7     
Impacted Files Coverage Δ
...eactivex/rxjava3/processors/BehaviorProcessor.java 97.48% <0.00%> (-2.52%) ⬇️
...ernal/operators/flowable/FlowableFlatMapMaybe.java 95.33% <0.00%> (-2.08%) ⬇️
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0.00%> (-1.99%) ⬇️
...tivex/rxjava3/internal/jdk8/ParallelCollector.java 96.33% <0.00%> (-1.84%) ⬇️
...va3/internal/operators/parallel/ParallelRunOn.java 98.53% <0.00%> (-1.47%) ⬇️
...internal/operators/flowable/FlowableSwitchMap.java 98.58% <0.00%> (-1.42%) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 93.66% <0.00%> (-1.41%) ⬇️
...rnal/operators/flowable/FlowableFlatMapSingle.java 94.76% <0.00%> (-1.17%) ⬇️
...operators/flowable/FlowableConcatMapScheduler.java 99.20% <0.00%> (-0.40%) ⬇️
...a3/internal/operators/flowable/FlowableReplay.java 98.71% <0.00%> (-0.22%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce45fc2...d9cf03c. Read the comment docs.

@akarnokd
Copy link
Member Author

akarnokd commented Sep 6, 2021

Closing in favor of #7241

@akarnokd akarnokd closed this Sep 6, 2021
@akarnokd akarnokd deleted the 3xWithModuleInfo branch September 6, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.x Consider adding a full Java module descriptor
1 participant