-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x Consider adding a full Java module descriptor #7240
Comments
Okay, as long as it doesn't break Android tooling. It seems we'll need a couple of things:
|
Correct. I must confess I know little of the Android ecosystem. It's my hope that additional entries found under |
MR jars will have their content ignored by Android toolchain, yes |
Great. @aalmiray you can post a PR for this. |
This is great. However in order to have RxJava's module descriptor be fully modular we'll need an answer from the ReactiveStreams WG -> reactive-streams/reactive-streams-jvm#531 |
FYI encountered bndtools/bnd#3514 -> bndtools/bnd#2227 which has yet to be resolved. |
Full Java module descriptors (module-info.class) are a hard requirement for building custom Java Runtimes with Jlink.
It looks like the build must remain pre Java modules however given that the build is Gradle based there's the https://plugins.gradle.org/plugin/org.beryx.jar plugin that can be applied to keep the build in its current Java version while at the same time providing a full module descriptor. Caveat: the generated JAR will become a multi-release JAR.
If there's any interest I'll gladly provide a PR and help with maintenance.
Relates to: reactive-streams/reactive-streams-jvm#531
The text was updated successfully, but these errors were encountered: