Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite core #4

Merged
merged 17 commits into from
Jul 29, 2024
Merged

feat: rewrite core #4

merged 17 commits into from
Jul 29, 2024

Conversation

Ravencentric
Copy link
Owner

@Ravencentric Ravencentric commented Jul 27, 2024

BREAKING CHANGES:

  • ArchiveFile.get_members() now returns a generator instead of a tuple
  • consistently return KeyError whenever a given member is not in the archive
  • raise NotImplementedError instead of custom UnsupportedArchiveOperationError

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (af23af2) to head (4a36c8c).

Additional details and impacted files
@@            Coverage Diff             @@
##              main        #4    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            7        11     +4     
  Lines          361       690   +329     
==========================================
+ Hits           361       690   +329     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ravencentric Ravencentric merged commit 8dd024e into main Jul 29, 2024
11 checks passed
@Ravencentric Ravencentric deleted the rewrite branch July 29, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant