-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to add tags to objects, racks and ipv4 networks + some doc updates + reports directory fixup #43
base: master
Are you sure you want to change the base?
Conversation
Thank you for suggesting this contribution. It looks like sara-nl#6 implements this functionality in a more generic way, have you looked at that proposed change? |
Thanks for the heads up, this looks interesting, I'll have a closer look. I find it disturbing to not have all effort stored in one repo, is there a list of all the active repos for racktables & plugins somewhere? |
Not as far as I know. I'd rather forward-port these old PRs into this new copy of this plugin and have only one copy to worry about. |
Hi Denis, I have integrated the changes you suggested and fixed the directory nesting in the reports plugin. Talking about reports, this version of the addon is really great and should be pushed upstream IMO (+ it would solve the hurdle of the manual copy of various files to install it). Also maybe it would be worthwhile to specify somewhere (repo README?) which plugins are 0.21's plugin format compatible. |
20e2b74
to
bbf2f37
Compare
…ne.de> & remove select *
I did some cleanup in the commits mess and added author for TAG (still learning git, sry...). Let me know if you need more udpates. BR |
Ping... |
Excuse me, I had other things to sort. I am going to make another look soon. |
No worries :) |
I am expecting to start this after finishing another work in about a week. |
That was very optimistic, please excuse me. |
No description provided.