Skip to content

Commit

Permalink
sort out codes of single column group by.
Browse files Browse the repository at this point in the history
  • Loading branch information
Rachelint committed Nov 13, 2024
1 parent 3a7dde3 commit ec1bc2c
Show file tree
Hide file tree
Showing 6 changed files with 31 additions and 9 deletions.
18 changes: 10 additions & 8 deletions datafusion/physical-plan/src/aggregates/group_values/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,24 +20,26 @@
use arrow::record_batch::RecordBatch;
use arrow_array::{downcast_primitive, ArrayRef};
use arrow_schema::{DataType, SchemaRef};
use bytes_view::GroupValuesBytesView;
use datafusion_common::Result;

pub(crate) mod primitive;
use datafusion_expr::EmitTo;
use primitive::GroupValuesPrimitive;

mod multi_column;
mod row;
mod single_column;
use datafusion_physical_expr::binary_map::OutputType;
use multi_column::GroupValuesColumn;
use row::GroupValuesRows;

mod bytes;
mod bytes_view;
use bytes::GroupValuesByes;
use datafusion_physical_expr::binary_map::OutputType;
pub(crate) use single_column::primitive::HashValue;

use crate::aggregates::order::GroupOrdering;
use crate::aggregates::{
group_values::single_column::{
bytes::GroupValuesByes, bytes_view::GroupValuesBytesView,
primitive::GroupValuesPrimitive,
},
order::GroupOrdering,
};

mod null_builder;

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

pub(crate) mod bytes;
pub(crate) mod bytes_view;
pub(crate) mod primitive;
2 changes: 1 addition & 1 deletion datafusion/physical-plan/src/aggregates/topk/hash_table.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

//! A wrapper around `hashbrown::RawTable` that allows entries to be tracked by index

use crate::aggregates::group_values::primitive::HashValue;
use crate::aggregates::group_values::HashValue;
use crate::aggregates::topk::heap::Comparable;
use ahash::RandomState;
use arrow::datatypes::i256;
Expand Down

0 comments on commit ec1bc2c

Please sign in to comment.