Apply ToolBox.updateTools() to all tools, not just class-based tools #5040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvanderlinde
force-pushed
the
fixup/pr-5019-tool-updates-for-instance-based-tools
branch
from
8cc976a
to
54b9a16
Compare
cwisniew
approved these changes
Nov 14, 2024
cwisniew
approved these changes
Nov 14, 2024
kwvanderlinde
deleted the
fixup/pr-5019-tool-updates-for-instance-based-tools
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fix PR #5019 so instance-based tools can be disabled.
Description of the Change
Toolbox.toolMapwas meant to only support class-based tool lookups. But there was one remaining usage where it was used to update tools based on theirisAvailable()method, overlooking instance-based tools in the process. This PR fixes things to checkisAvailable()for all tools, whether instanced-based or class-based.Possible Drawbacks
None
Documentation Notes
N/A
Release Notes
N/A
This change is