Changed all references and pointers to Handle to be const

ROCm · Nov 22, 2024 · 5d8038b · 5d8038b
1 parent d16aed9
commit 5d8038b
Show file tree

Hide file tree

Showing 102 changed files with 334 additions and 318 deletions.
diff --git a/src/adam.cpp b/src/adam.cpp
@@ -35,7 +35,7 @@
 
 namespace miopen {
 
-miopenStatus_t Adam(Handle& handle,
+miopenStatus_t Adam(Handle const& handle,
                     const TensorDescriptor& paramInDesc,
                     ConstData_t paramIn,
                     const TensorDescriptor& paramOutDesc,

diff --git a/src/addlayernorm.cpp b/src/addlayernorm.cpp
@@ -34,7 +34,7 @@
 
 namespace miopen {
 
-miopenStatus_t AddLayerNormForward(Handle& handle,
+miopenStatus_t AddLayerNormForward(Handle const& handle,
                                    const TensorDescriptor& xDesc,
                                    ConstData_t x,
                                    const TensorDescriptor& x2Desc,

diff --git a/src/cat.cpp b/src/cat.cpp
@@ -35,7 +35,7 @@
 
 namespace miopen {
 
-miopenStatus_t CatForward(Handle& handle,
+miopenStatus_t CatForward(Handle const& handle,
                           int32_t xCount,
                           const TensorDescriptor* const* xDescs,
                           ConstData_t* xs,

diff --git a/src/conv/solver_finders.cpp b/src/conv/solver_finders.cpp
@@ -214,7 +214,7 @@ const std::vector<std::unique_ptr<ISolversFinder>>& GetConvSolverFinders()
 } // namespace conv
 
 /// Register invoker only for the best solution within algorithm.
-static std::vector<Solution> EvaluateInvokers(Handle& handle,
+static std::vector<Solution> EvaluateInvokers(Handle const& handle,
                                               const std::vector<solver::ConvSolution>& solutions,
                                               const AlgorithmName& algorithm_name,
                                               const NetworkConfig& network_config,

diff --git a/src/ctc.cpp b/src/ctc.cpp
@@ -37,7 +37,7 @@ CTCLossDescriptor::CTCLossDescriptor()
     blank_label_id      = 0;
 }
 
-size_t CTCLossDescriptor::GetCTCLossWorkspaceSize(Handle& handle,
+size_t CTCLossDescriptor::GetCTCLossWorkspaceSize(Handle const& handle,
                                                   const TensorDescriptor& probsDesc,
                                                   const TensorDescriptor& gradientsDesc,
                                                   const int* labels,

diff --git a/src/find_db.cpp b/src/find_db.cpp
@@ -55,7 +55,8 @@ boost::optional<fs::path>& testing_find_db_path_override()
 
 #if MIOPEN_EMBED_DB
 template <class TDb>
-fs::path FindDbRecord_t<TDb>::GetInstalledPathEmbed(Handle& handle, const std::string& path_suffix)
+fs::path FindDbRecord_t<TDb>::GetInstalledPathEmbed(Handle const& handle,
+                                                    const std::string& path_suffix)
 {
     static const auto embed_path = [&] {
         const std::string ext = ".fdb.txt";
@@ -121,7 +122,8 @@ fs::path FindDbRecord_t<TDb>::GetInstalledPathEmbed(Handle& handle, const std::s
 #else
 
 template <class TDb>
-fs::path FindDbRecord_t<TDb>::GetInstalledPathFile(Handle& handle, const std::string& path_suffix)
+fs::path FindDbRecord_t<TDb>::GetInstalledPathFile(Handle const& handle,
+                                                   const std::string& path_suffix)
 {
     static const auto installed_path = [&] {
         const std::string ext = ".fdb.txt";
@@ -197,7 +199,7 @@ fs::path FindDbRecord_t<TDb>::GetInstalledPathFile(Handle& handle, const std::st
 }
 #endif
 template <class TDb>
-fs::path FindDbRecord_t<TDb>::GetInstalledPath(Handle& handle, const std::string& path_suffix)
+fs::path FindDbRecord_t<TDb>::GetInstalledPath(Handle const& handle, const std::string& path_suffix)
 {
 #if !MIOPEN_DISABLE_SYSDB
 #if MIOPEN_EMBED_DB
@@ -213,7 +215,7 @@ fs::path FindDbRecord_t<TDb>::GetInstalledPath(Handle& handle, const std::string
 }
 
 template <class TDb>
-fs::path FindDbRecord_t<TDb>::GetUserPath(Handle& handle, const std::string& path_suffix)
+fs::path FindDbRecord_t<TDb>::GetUserPath(Handle const& handle, const std::string& path_suffix)
 {
 #if !MIOPEN_DISABLE_USERDB
     return GetUserDbPath() / (handle.GetDbBasename() + '.' + GetUserDbSuffix() +
@@ -226,7 +228,7 @@ fs::path FindDbRecord_t<TDb>::GetUserPath(Handle& handle, const std::string& pat
 }
 
 template <class TDb>
-bool FindDbRecord_t<TDb>::Validate(Handle& handle, const NetworkConfig& config) const
+bool FindDbRecord_t<TDb>::Validate(Handle const& handle, const NetworkConfig& config) const
 {
     auto unbuilt = false;
     auto any     = false;

diff --git a/src/fusion.cpp b/src/fusion.cpp
@@ -54,7 +54,7 @@
 
 namespace miopen {
 
-miopenStatus_t ConvBiasActivFusion(Handle& handle,
+miopenStatus_t ConvBiasActivFusion(Handle const& handle,
                                    const void* alpha1,
                                    const TensorDescriptor& xDesc,
                                    ConstData_t x,
@@ -137,7 +137,7 @@ miopenStatus_t ConvBiasActivFusion(Handle& handle,
 }
 
 static auto
-AllocateBuffersAndMakeFusionInvokeParams(Handle& handle,
+AllocateBuffersAndMakeFusionInvokeParams(Handle const& handle,
                                          const FusionDescription& problem,
                                          std::vector<Allocator::ManageDataPtr>& invoke_bufs,
                                          miopen::OperatorArgs& params,
@@ -490,7 +490,7 @@ TensorDescriptor FusionPlanDescriptor::FusionPlanDescriptor::DeriveOutputDescrip
     return o_desc;
 }
 
-miopenStatus_t FusionPlanDescriptor::GetWorkspaceSizeImmed(Handle& handle,
+miopenStatus_t FusionPlanDescriptor::GetWorkspaceSizeImmed(Handle const& handle,
                                                            size_t& workSpaceSize,
                                                            miopenConvFwdAlgorithm_t /*algo*/)
 {
@@ -969,7 +969,7 @@ std::vector<miopenConvSolution_t> GetSolutions(const FusionContext& ctx,
 
 } // namespace
 
-miopenStatus_t FusionPlanDescriptor::Compile(Handle& handle)
+miopenStatus_t FusionPlanDescriptor::Compile(Handle const& handle)
 {
     std::vector<Allocator::ManageDataPtr> invoke_bufs;
     miopen::OperatorArgs params;
@@ -1097,7 +1097,7 @@ miopenStatus_t FusionPlanDescriptor::Compile(Handle& handle)
 }
 
 std::vector<Solution>
-FusionPlanDescriptor::Find(Handle& handle,
+FusionPlanDescriptor::Find(Handle const& handle,
                            const std::function<fusion::FusionInvokeParams()>& invoke_params,
                            const std::optional<FindOptions>& options) const
 {

diff --git a/src/getitem.cpp b/src/getitem.cpp
@@ -35,7 +35,7 @@
 
 namespace miopen {
 
-std::size_t GetGetitemWorkspaceSize(Handle& handle,
+std::size_t GetGetitemWorkspaceSize(Handle const& handle,
                                     uint32_t indexCount,
                                     const TensorDescriptor* const* indexDescs)
 {
@@ -50,7 +50,7 @@ std::size_t GetGetitemWorkspaceSize(Handle& handle,
     return pair_size_vector.empty() ? static_cast<size_t>(0) : pair_size_vector.front().second;
 }
 
-miopenStatus_t GetitemBackward(Handle& handle,
+miopenStatus_t GetitemBackward(Handle const& handle,
                                Data_t workspace,
                                size_t workspaceSizeInBytes,
                                const TensorDescriptor& dyDesc,

diff --git a/src/glu.cpp b/src/glu.cpp
@@ -37,7 +37,7 @@ namespace miopen {
 
 namespace glu {
 
-miopenStatus_t GLUForward(Handle& handle,
+miopenStatus_t GLUForward(Handle const& handle,
                           const TensorDescriptor& inputDesc,
                           ConstData_t input,
                           const TensorDescriptor& outputDesc,
@@ -65,7 +65,7 @@ miopenStatus_t GLUForward(Handle& handle,
     return miopenStatusSuccess;
 }
 
-miopenStatus_t GLUBackward(Handle& handle,
+miopenStatus_t GLUBackward(Handle const& handle,
                            const TensorDescriptor& inputDesc,
                            ConstData_t input,
                            const TensorDescriptor& outputGradDesc,

diff --git a/src/groupnorm.cpp b/src/groupnorm.cpp
@@ -33,7 +33,7 @@
 
 namespace miopen {
 
-miopenStatus_t GroupNormForward(Handle& handle,
+miopenStatus_t GroupNormForward(Handle const& handle,
                                 const TensorDescriptor& xDesc,
                                 ConstData_t x,
                                 const TensorDescriptor& weightDesc,

diff --git a/src/hip/handlehip.cpp b/src/hip/handlehip.cpp
@@ -755,7 +755,7 @@ std::size_t Handle::GetWavefrontWidth() const
 
 // No HIP API that could return maximum memory allocation size
 // for a single object.
-std::size_t Handle::GetMaxMemoryAllocSize()
+std::size_t Handle::GetMaxMemoryAllocSize() const
 {
     if(m_MaxMemoryAllocSizeCached == 0)
     {

diff --git a/src/include/miopen/activ.hpp b/src/include/miopen/activ.hpp
@@ -50,7 +50,7 @@ struct MIOPEN_INTERNALS_EXPORT ActivationDescriptor : miopenActivationDescriptor
     double GetBeta() const;
     double GetGamma() const;
 
-    miopenStatus_t Forward(Handle& handle,
+    miopenStatus_t Forward(Handle const& handle,
                            const void* alpha,
                            const TensorDescriptor& xDesc,
                            ConstData_t x,
@@ -60,7 +60,7 @@ struct MIOPEN_INTERNALS_EXPORT ActivationDescriptor : miopenActivationDescriptor
                            size_t xOffset = 0,
                            size_t yOffset = 0) const;
 
-    miopenStatus_t Backward(Handle& handle,
+    miopenStatus_t Backward(Handle const& handle,
                             const void* alpha,
                             const TensorDescriptor& yDesc,
                             ConstData_t y,

diff --git a/src/include/miopen/adam.hpp b/src/include/miopen/adam.hpp
@@ -33,7 +33,7 @@ namespace miopen {
 struct Handle;
 struct TensorDescriptor;
 
-MIOPEN_INTERNALS_EXPORT miopenStatus_t Adam(Handle& handle,
+MIOPEN_INTERNALS_EXPORT miopenStatus_t Adam(Handle const& handle,
                                             const TensorDescriptor& paramInDesc,
                                             ConstData_t paramIn,
                                             const TensorDescriptor& paramOutDesc,
@@ -74,7 +74,7 @@ MIOPEN_INTERNALS_EXPORT miopenStatus_t Adam(Handle& handle,
                                             bool is_amp);
 
 MIOPEN_INTERNALS_EXPORT miopenStatus_t
-TransformersAdamW(Handle& handle,
+TransformersAdamW(Handle const& handle,
                   const TensorDescriptor& paramInDesc,
                   ConstData_t paramIn,
                   const TensorDescriptor& paramOutDesc,

diff --git a/src/include/miopen/addlayernorm.hpp b/src/include/miopen/addlayernorm.hpp
@@ -33,7 +33,7 @@ namespace miopen {
 struct Handle;
 struct TensorDescriptor;
 
-MIOPEN_INTERNALS_EXPORT miopenStatus_t AddLayerNormForward(Handle& handle,
+MIOPEN_INTERNALS_EXPORT miopenStatus_t AddLayerNormForward(Handle const& handle,
                                                            const TensorDescriptor& xDesc,
                                                            ConstData_t x,
                                                            const TensorDescriptor& x2Desc,

diff --git a/src/include/miopen/batch_norm.hpp b/src/include/miopen/batch_norm.hpp
@@ -163,7 +163,7 @@ void bnFwdTrainSelectMulti(const Handle& handle,
 
 void profileSequence(const Handle& handle, unsigned char select, float* ctime);
 
-MIOPEN_INTERNALS_EXPORT void BatchNormForwardInference(Handle& handle,
+MIOPEN_INTERNALS_EXPORT void BatchNormForwardInference(Handle const& handle,
                                                        miopenBatchNormMode_t bn_mode,
                                                        const void* alpha,
                                                        const void* beta,
@@ -181,7 +181,7 @@ MIOPEN_INTERNALS_EXPORT void BatchNormForwardInference(Handle& handle,
                                                        ConstData_t estimatedVariance,
                                                        double epsilon);
 
-MIOPEN_INTERNALS_EXPORT void BatchNormForwardTraining(Handle& handle,
+MIOPEN_INTERNALS_EXPORT void BatchNormForwardTraining(Handle const& handle,
                                                       miopenBatchNormMode_t bn_mode,
                                                       const void* alpha,
                                                       const void* beta,
@@ -202,7 +202,7 @@ MIOPEN_INTERNALS_EXPORT void BatchNormForwardTraining(Handle& handle,
                                                       Data_t resultSaveMean,
                                                       Data_t resultSaveInvVariance);
 
-MIOPEN_INTERNALS_EXPORT void BatchNormBackward(Handle& handle,
+MIOPEN_INTERNALS_EXPORT void BatchNormBackward(Handle const& handle,
                                                miopenBatchNormMode_t bn_mode,
                                                const void* alphaDataDiff,
                                                const void* betaDataDiff,

diff --git a/src/include/miopen/cat.hpp b/src/include/miopen/cat.hpp
@@ -33,7 +33,7 @@ namespace miopen {
 struct Handle;
 struct TensorDescriptor;
 
-MIOPEN_INTERNALS_EXPORT miopenStatus_t CatForward(Handle& handle,
+MIOPEN_INTERNALS_EXPORT miopenStatus_t CatForward(Handle const& handle,
                                                   int32_t xCount,
                                                   const TensorDescriptor* const* xDescs,
                                                   ConstData_t* xs,

diff --git a/src/include/miopen/convolution.hpp b/src/include/miopen/convolution.hpp
@@ -197,7 +197,7 @@ struct MIOPEN_INTERNALS_EXPORT ConvolutionDescriptor : miopenConvolutionDescript
     std::size_t GetWorkSpaceSize(ExecutionContext ctx,
                                  const conv::ProblemDescription& problem) const;
 
-    void FindConvFwdAlgorithm(Handle& handle,
+    void FindConvFwdAlgorithm(Handle const& handle,
                               const TensorDescriptor& xDesc,
                               ConstData_t x,
                               const TensorDescriptor& wDesc,
@@ -211,7 +211,7 @@ struct MIOPEN_INTERNALS_EXPORT ConvolutionDescriptor : miopenConvolutionDescript
                               std::size_t workSpaceSize,
                               bool exhaustiveSearch) const;
 
-    void ConvolutionForward(Handle& handle,
+    void ConvolutionForward(Handle const& handle,
                             const void* alpha,
                             const TensorDescriptor& xDesc,
                             ConstData_t x,
@@ -238,13 +238,13 @@ struct MIOPEN_INTERNALS_EXPORT ConvolutionDescriptor : miopenConvolutionDescript
                          const conv::ProblemDescription& problem,
                          solver::Id solver_id) const;
 
-    std::size_t GetForwardSolutionWorkspaceSize(Handle& handle,
+    std::size_t GetForwardSolutionWorkspaceSize(Handle const& handle,
                                                 const TensorDescriptor& wDesc,
                                                 const TensorDescriptor& xDesc,
                                                 const TensorDescriptor& yDesc,
                                                 solver::Id solver_id) const;
 
-    void ConvolutionForwardImmediate(Handle& handle,
+    void ConvolutionForwardImmediate(Handle const& handle,
                                      const TensorDescriptor& wDesc,
                                      ConstData_t w,
                                      const TensorDescriptor& xDesc,
@@ -255,7 +255,7 @@ struct MIOPEN_INTERNALS_EXPORT ConvolutionDescriptor : miopenConvolutionDescript
                                      std::size_t workSpaceSize,
                                      solver::Id solver_id) const;
 
-    void FindConvBwdDataAlgorithm(Handle& handle,
+    void FindConvBwdDataAlgorithm(Handle const& handle,
                                   const TensorDescriptor& dyDesc,
                                   ConstData_t dy,
                                   const TensorDescriptor& wDesc,
@@ -269,7 +269,7 @@ struct MIOPEN_INTERNALS_EXPORT ConvolutionDescriptor : miopenConvolutionDescript
                                   std::size_t workSpaceSize,
                                   bool exhaustiveSearch) const;
 
-    void ConvolutionBackwardData(Handle& handle,
+    void ConvolutionBackwardData(Handle const& handle,
                                  const void* alpha,
                                  const TensorDescriptor& dyDesc,
                                  ConstData_t dy,
@@ -282,13 +282,13 @@ struct MIOPEN_INTERNALS_EXPORT ConvolutionDescriptor : miopenConvolutionDescript
                                  Data_t workSpace,
                                  std::size_t workSpaceSize) const;
 
-    std::size_t GetBackwardSolutionWorkspaceSize(Handle& handle,
+    std::size_t GetBackwardSolutionWorkspaceSize(Handle const& handle,
                                                  const TensorDescriptor& dyDesc,
                                                  const TensorDescriptor& wDesc,
                                                  const TensorDescriptor& dxDesc,
                                                  solver::Id solver_id) const;
 
-    void ConvolutionBackwardImmediate(Handle& handle,
+    void ConvolutionBackwardImmediate(Handle const& handle,
                                       const TensorDescriptor& dyDesc,
                                       ConstData_t dy,
                                       const TensorDescriptor& wDesc,
@@ -299,13 +299,13 @@ struct MIOPEN_INTERNALS_EXPORT ConvolutionDescriptor : miopenConvolutionDescript
                                       std::size_t workSpaceSize,
                                       solver::Id solver_id) const;
 
-    std::size_t GetWrwSolutionWorkspaceSize(Handle& handle,
+    std::size_t GetWrwSolutionWorkspaceSize(Handle const& handle,
                                             const TensorDescriptor& dyDesc,
                                             const TensorDescriptor& xDesc,
                                             const TensorDescriptor& dwDesc,
                                             solver::Id solver_id) const;
 
-    void ConvolutionWrwImmediate(Handle& handle,
+    void ConvolutionWrwImmediate(Handle const& handle,
                                  const TensorDescriptor& dyDesc,
                                  ConstData_t dy,
                                  const TensorDescriptor& xDesc,
@@ -316,7 +316,7 @@ struct MIOPEN_INTERNALS_EXPORT ConvolutionDescriptor : miopenConvolutionDescript
                                  std::size_t workSpaceSize,
                                  solver::Id solver_id) const;
 
-    void FindConvBwdWeightsAlgorithm(Handle& handle,
+    void FindConvBwdWeightsAlgorithm(Handle const& handle,
                                      const TensorDescriptor& dyDesc,
                                      ConstData_t dy,
                                      const TensorDescriptor& xDesc,

diff --git a/src/include/miopen/ctc.hpp b/src/include/miopen/ctc.hpp
@@ -48,15 +48,15 @@ struct MIOPEN_INTERNALS_EXPORT CTCLossDescriptor : miopenCTCLossDescriptor
     bool apply_softmax_layer;
     int blank_label_id;
 
-    size_t GetCTCLossWorkspaceSize(Handle& handle,
+    size_t GetCTCLossWorkspaceSize(Handle const& handle,
                                    const TensorDescriptor& probsDesc,
                                    const TensorDescriptor& gradientsDesc,
                                    const int* labels,
                                    const int* labelLengths,
                                    const int* inputLengths,
                                    miopenCTCLossAlgo_t algo) const;
 
-    void CTCLoss(Handle& handle,
+    void CTCLoss(Handle const& handle,
                  const TensorDescriptor& probsDesc,
                  ConstData_t probs,
                  const int* labels,

diff --git a/src/include/miopen/dropout.hpp b/src/include/miopen/dropout.hpp
@@ -68,7 +68,7 @@ struct MIOPEN_INTERNALS_EXPORT DropoutDescriptor : miopenDropoutDescriptor
 
     miopenDataType_t dataType_;
 
-    void InitPRNGState(Handle& handle,
+    void InitPRNGState(Handle const& handle,
                        Data_t prng_states,
                        size_t prng_stateSizeInBytes,
                        unsigned long long prng_seed) const;