Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R executable selection #1143

Closed
wants to merge 23 commits into from
Closed

Commits on Jul 19, 2022

  1. R executable selection

    ElianHugh committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    83f70a2 View commit details
    Browse the repository at this point in the history
  2. R --version & reduced process creation

    - Use R --version for details
    - Only create executables when calling refreshPaths()
    ElianHugh committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    ce25dc3 View commit details
    Browse the repository at this point in the history
  3. Tooltip fixes

    Prevent outputting malformed tooltips when executable arch or version is undefined
    ElianHugh committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    c8f7f6c View commit details
    Browse the repository at this point in the history
  4. Refactor + simplify executable access

    Executables access is now handled purely through the RExecutableManager, rather than any member classes
    ElianHugh committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    fd1b174 View commit details
    Browse the repository at this point in the history
  5. Binary recommendations, fix undefined, revert LSP changes

    - Revert language service changes
        - need to look at how python does it
    - Recommend binaries that are in the workspace or are specified by a renv lockfile
    - Fix possibly undefined issues
    - Normalise path for windows
    - Update vscode types and engine to 1.65
    - Async init method for the manager
    ElianHugh committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    82b08de View commit details
    Browse the repository at this point in the history
  6. Update r.rmarkdown.codeLensCommands

    Use an enum to restrict the input for the setting: r.rmarkdown.codeLensCommands
    ElianHugh committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    f5a6075 View commit details
    Browse the repository at this point in the history
  7. Fix rebase bug, lint error

    Enum change was pushed to package.json for some reason
    ElianHugh committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    fe5e42f View commit details
    Browse the repository at this point in the history
  8. Improve quickpick categories

    QP items now grouped into
    - recommended
    - virtual
    - global
    
    - Changed various functions into arrow functions to pass `'this'
    ElianHugh committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    a2fe14a View commit details
    Browse the repository at this point in the history
  9. WIP windows support

    ElianHugh committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    403dd48 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9861289 View commit details
    Browse the repository at this point in the history
  11. Task rpath, path settings machine-overridable

    - rpath is machine-overridable
    - task rpath dependent on active workspace executable
    - quickpick shows arrow for active path
    ElianHugh committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    b4bb2fa View commit details
    Browse the repository at this point in the history
  12. Show error when selecting a bad installation

    Error is triggered when selecting an R installation that cannot be opened
    ElianHugh committed Jul 19, 2022
    Configuration menu
    Copy the full SHA
    8f49eb4 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. Inject conda values

    - Create R terminal now injects  conda env values where appropriate
    - Conda env values are saved in /tmp/ for injection into processes
    ElianHugh committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    60a6e7b View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Configuration menu
    Copy the full SHA
    b4f3b48 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2022

  1. Refactoring

    Minor stylistic changes, no behaviour change
    ElianHugh committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    d247d4b View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Configuration menu
    Copy the full SHA
    a32c2c3 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Add tests

    ElianHugh committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    ebf9821 View commit details
    Browse the repository at this point in the history
  2. Tests, rPath, linter fix

    Add tests for pathStorage,
    make rPath === activeExecPath again,
    linter
    ElianHugh committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    6ffd5ca View commit details
    Browse the repository at this point in the history
  3. Conda settings

    ElianHugh committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    77669c4 View commit details
    Browse the repository at this point in the history
  4. rTerm uses executables

    terminals once again respect activeExecutable
    ElianHugh committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    57fd216 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Minor changes

    - Add documentation for various classes
    - Ensure that superfluous `await`s are removed
    - Rename some types for clarity
    ElianHugh committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    25ed0c5 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. Configuration menu
    Copy the full SHA
    0366abe View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. No user-facing changes

    ElianHugh committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    768a006 View commit details
    Browse the repository at this point in the history