-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial code to add the search functionnality onto the a small viewport #6966
base: main
Are you sure you want to change the base?
Conversation
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start. Can't you reuse the search icon from the desktop view?
Search | ||
</Modal.Trigger> | ||
<Modal.Panel class="w-full h-full"> | ||
{state.isOpen && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually if you feel up to it, it would be cool to change the docsearchmodal so it uses sync$ instead of all those noSerialize things and then the search box will be instantly available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the noSerialize scope over some variables (state) and from what I read that a no good? i am missing something 👀
Added the icon back and made it possible to control the Modal from An external controller |
What is it?
Description
I was able to achieve decent behavior by utilizing the QwikUI modal component. The current implementation resulted in the component being partially hidden (off-screen) above pictue. Additionally, the implementation is missing a proper search button icon
I'm sharing this here to gather feedback on my progress so far.
Related issue: #6949
Please feel free to review and provide any suggestions or improvements.
Checklist:
pnpm change
and documented my changes