Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[afqmc] implement < for device pointer #5242

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[afqmc] implement < for device pointer #5242

merged 2 commits into from
Nov 26, 2024

Conversation

correaa
Copy link
Contributor

@correaa correaa commented Nov 26, 2024

Proposed changes

make afqmc device pointer a proper pointer by providing comparison

What type(s) of changes does this code introduce?

  • Refactoring (no functional changes, no api changes)

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

Ubuntu 24.04

Checklist

  • Yes. This PR is up to date with current the current state of 'develop'
  • No. Code added or changed in the PR has been clang-formatted
  • No. This PR adds tests to cover any new code, or to catch a bug that is being fixed
  • No. Documentation has been added (if appropriate)

@prckent
Copy link
Contributor

prckent commented Nov 26, 2024

Test this please

@ye-luo ye-luo merged commit 2f961ad into QMCPACK:develop Nov 26, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prckent prckent prckent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@correaa @prckent @ye-luo