Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications bug #751

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Notifications bug #751

merged 2 commits into from
Apr 17, 2023

Conversation

JoeBatt1989
Copy link
Contributor

@JoeBatt1989 JoeBatt1989 commented Apr 17, 2023 •
edited
Loading

Description

Fixes #750

A few sentences describing the changes proposed in this pull request.

Status

Ready

Types of changes

  • [x ] Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • [x ] All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@sonarcloud
Copy link

sonarcloud bot commented Apr 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

55.6% 55.6% Coverage
0.0% 0.0% Duplication

@JoeBatt1989 JoeBatt1989 merged commit 5297c24 into develop Apr 17, 2023
@mocsharp mocsharp deleted the notificationsBug branch June 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neildsouth neildsouth neildsouth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeBatt1989 @neildsouth