vista3d_ohifv3 support #1771
Closed
vista3d_ohifv3 support #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tangy5 <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: tangy5 <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: tangy5 <[email protected]>
Signed-off-by: tangy5 <[email protected]>
Signed-off-by: tangy5 <[email protected]>
tangy5
force-pushed
the
vista_ohif_support
branch
from
e93afe2
to
2a9e7ee
Compare
Signed-off-by: tangy5 <[email protected]>
tangy5
force-pushed
the
vista_ohif_support
branch
from
140c4e6
to
c5ec51d
Compare
Signed-off-by: tangy5 <[email protected]>
tangy5
force-pushed
the
vista_ohif_support
branch
from
9664880
to
3b2beb5
Compare
Signed-off-by: tangy5 <[email protected]>
tangy5
force-pushed
the
vista_ohif_support
branch
from
71dfeef
to
80139f3
Compare
| @@ -0,0 +1,136 @@ | |||
| from typing import Any, Dict | |||
There was a problem hiding this comment.
when vista3d bundle is used.. why we need to have this related code in monailabel?
| @@ -82,8 +82,8 @@ def __init__( | |||
| conf: Dict[str, str], | |||
| const: Optional[BundleConstants] = None, | |||
| type: Union[str, InferType] = "", | |||
| pre_filter: Optional[Sequence] = None, | |||
| post_filter: Optional[Sequence] = [SaveImaged], | |||
| pre_filter: Optional[Sequence] = [CropForegroundd], | |||
There was a problem hiding this comment.
any reasons why we needed these changes? which is applicable to everyone
| @@ -19,4 +19,5 @@ mkdir -p www/html | |||
| cp -r ../../monailabel/endpoints/static/ohif www/html/ohif | |||
| cp -f config/monai_label.js www/html/ohif/app-config.js | |||
|
|
|||
| nginx -p `pwd` -c config/nginx.conf -e logs/error.log | |||
| # nginx -p `pwd` -c config/nginx.conf -e logs/error.log | |||
| nginx -p `pwd` -c config/nginx.conf | |||
There was a problem hiding this comment.
default path for error log (/var/log something..) may not have permissions
| @@ -0,0 +1,257 @@ | |||
| export const segmentColors: { [key: number]: string } = { | |||
| 1: '#dd5454', | |||
There was a problem hiding this comment.
what are these colors for?
| onSegmentation = async () => { | ||
| const nid = this.notification.show({ | ||
| title: 'MONAI Label', | ||
| message: 'Running Auto-Segmentation...', | ||
| type: 'info', | ||
| duration: 60000, | ||
| duration: 6000, |
There was a problem hiding this comment.
6 seconds vs 60 seconds to allow to finish the auto segmentation?
| @@ -219,7 +219,7 @@ export default class OptionTable extends BaseTab { | |||
| id={this.tabId} | |||
| name="activelearning" | |||
| value="activelearning" | |||
| defaultChecked | |||
| // defaultChecked | |||
There was a problem hiding this comment.
any reasons why default is changed?
|
OHIF V3 is tracked via: #1785 Please use branch: https://github.com/Project-MONAI/MONAILabel/tree/sachi/ohifv3 to verify vista3d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working on cleaning, and merge the ohif_vista and ohifv3, we need single build config for ohifv3.
To support point based probe tools.