Fix ImportError for IgniteInfo #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangy5
approved these changes
Sep 30, 2024
|
are these changes not needed anymore? |
Hi @SachidanandAlle, no, the change still need, but it may need the next release from monai to help ci pass. Thanks. |
|
Hi @SachidanandAlle and @tangy5, we may need drop python 3.8 support here since monai has dropped so it can not install 1.4.0rc in the ci. |
|
Since the setting in the workflow only use the one on the main branch, ci can still not pass. Will leave this pr here since I don't want change too much in the config yaml for monailabel. I also have a workaround in monai core already merged, Project-MONAI/MONAI#8121 So we can leave the pr here and update it later. |
Signed-off-by: YunLiu <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
updates: - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) - [github.com/psf/black: 24.3.0 → 24.4.2](psf/black@24.3.0...24.4.2) - [github.com/psf/black: 24.3.0 → 24.4.2](psf/black@24.3.0...24.4.2) - [github.com/PyCQA/flake8: 7.0.0 → 7.1.0](PyCQA/flake8@7.0.0...7.1.0) - [github.com/pre-commit/mirrors-mypy: v1.9.0 → v1.10.1](pre-commit/mirrors-mypy@v1.9.0...v1.10.1) - [github.com/asottile/pyupgrade: v3.15.2 → v3.16.0](asottile/pyupgrade@v3.15.2...v3.16.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: SACHIDANAND ALLE <[email protected]> Signed-off-by: YunLiu <[email protected]>
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.2.1 to 2.2.2. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.2.1...2.2.2) --- updated-dependencies: - dependency-name: urllib3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: YunLiu <[email protected]>
Bumps [requests](https://github.com/psf/requests) from 2.31.0 to 2.32.2. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.31.0...v2.32.2) --- updated-dependencies: - dependency-name: requests dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: YunLiu <[email protected]>
Pinning basic packages such as "requests" to a specific patch level release such "2.31.0" is too strict. New releases and especially new patch releases allow to use latest security updates of various packages. Signed-off-by: James Butler <[email protected]> Co-authored-by: SACHIDANAND ALLE <[email protected]> Signed-off-by: YunLiu <[email protected]>
* Release 0.8.4 checks and updates Signed-off-by: tangy5 <[email protected]> * Trigger monai container update Signed-off-by: tangy5 <[email protected]> * Drop python 3.8 Signed-off-by: tangy5 <[email protected]> * Drop python 3.8 Signed-off-by: tangy5 <[email protected]> --------- Signed-off-by: tangy5 <[email protected]> Co-authored-by: tangy5 <[email protected]> Signed-off-by: YunLiu <[email protected]>
Signed-off-by: Ashis Ravindran <[email protected]> Signed-off-by: YunLiu <[email protected]>
* Add MITK as supported platform Signed-off-by: Ashis Ravindran <[email protected]> * Update link to MONAI Label repo Signed-off-by: Ashis Ravindran <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Ashis Ravindran <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Using transforms from MONAI and MONAILabel can result in metadata containing torch.tensors and torch.Sizes. This change fixes a traceback in the restored transform resulting from an incompatibility between torch datatypes and numpy.any(). Signed-off-by: Thomas Kierski <[email protected]> Signed-off-by: YunLiu <[email protected]>
This reverts commit 8ced475. Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
Signed-off-by: YunLiu <[email protected]>
|
Hi @tangy5, this one can be merged now. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue caused by Project-MONAI/MONAI#8113