Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the nav bar and the position of sun icon #465

Closed
wants to merge 1 commit into from

Conversation

samardotexe
Copy link

@samardotexe samardotexe commented Oct 10, 2024

Related Issue

The toggle icon for dark mode isn't responding

Fixes: #451

Description

The navbar isn't visible on white background so I adjusted the shadow of text and improved visibility and the toggle icon for dark mode was not aligned properly. I adjusted it and fixed the position as well

Type of PR

  • [x ] Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Checklist:

  • [ x] I have made this change from my own.
  • [ x] I have taken help from some online resources.
  • [ x] My code follows the style guidelines of this project.
  • [ x] I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • [ x] My changes generate no new warnings.
  • [ x] I have tested the changes thoroughly before submitting this pull request.
  • [ x] have provided relevant issue numbers and screenshots after making the changes.

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 11:24am

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for buddytrail failed. Why did it fail? →

Name Link
🔨 Latest commit 5262985
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/6707b95bb36cda000864e571

@PriyaGhosal
Copy link
Owner

@Samar-Ali-Ansari Please see the conflicts . Resolve the conflicts . Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CODE CHANGE: The nav bar is clearly invisible when it comes to white background
2 participants