Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #241 Improve the UI of the Navbar #245

Closed
wants to merge 2 commits into from

Conversation

Aradhya-005
Copy link
Contributor

Fixes: #241
Screenshot 2024-10-08 034758

The changes I made include:

  • Making the navbar background transparent to make it look good
  • Aligning nav items properly using Flexbox
  • Adding JavaScript to change the navbar color while scrolling
    Additionally, I:
  • Set the hero image height to 100vh for a full-screen.
  • Adjusted the button size for better UI

Copy link

vercel bot commented Oct 7, 2024

Deployment failed with the following error:

Resource is limited - try again in 6 hours (more than 100, code: "api-deployments-free-per-day").

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@PriyaGhosal
Copy link
Owner

image
@Aradhya-005 Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!

@PriyaGhosal PriyaGhosal closed this Oct 8, 2024
PriyaGhosal added a commit that referenced this pull request Oct 8, 2024
fixed #241 Improve the UI of the Navbar #245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the UI of the Navbar
2 participants