Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Several Minor Issues & Page Restructured #1837

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

Adarsh-Chaubey03
Copy link
Contributor

@Adarsh-Chaubey03 Adarsh-Chaubey03 commented Oct 31, 2024

Related Issue

Fixing Several Minor Issues Simultaneously

Due to recent pull requests being merged, the BuddyTrail website has developed several bugs from unresolved or incorrectly resolved conflicts. Issues include duplicate footers, misaligned and extra text, and other common problems. Going forward, I’ll group more issues together to handle multiple fixes in a single PR. This approach will allow me to contribute more effectively and avoid any perception of spam.

Fixes: #1835

Description

Cookie Policy page was completely disturbed

  • THEN
    image
  • NOW
    image

Hotel Page Nav Bar is now have no margin on top. Deleted extra text above nav bar

  • then
    image
  • now
    image

footer of copyright page was disturbed and have useless text below it

  • then
    image
  • now
    image

himachal treck page had different picture sizes causing uneven tile ; also it was not linked with himachal.css file

image
image

similar issue on rajasthan page

  • then
    image
  • now
    image

Type of PR

  • Bug fix

  • Feature enhancement

  • I have made this change from my own.

  • I have taken help from some online resources.

  • My code follows the style guidelines of this project.

  • I have performed a self-review of my own code.

  • I have commented my code, particularly in hard-to-understand areas.

  • I have made corresponding changes to the documentation.

  • My changes generate no new warnings.

  • I have tested the changes thoroughly before submitting this pull request.

  • I have provided relevant issue numbers and screenshots after making the changes.
    @PriyaGhosal please review this pr

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buddy-trail ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 8:02pm

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our contributing.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for buddytrail ready!

Name Link
🔨 Latest commit d14d4eb
🔍 Latest deploy log https://app.netlify.com/sites/buddytrail/deploys/6723e2591868b600085d08d4
😎 Deploy Preview https://deploy-preview-1837--buddytrail.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PriyaGhosal PriyaGhosal merged commit d8a34ab into PriyaGhosal:main Nov 5, 2024
6 of 8 checks passed
@PriyaGhosal
Copy link
Owner

@Adarsh-Chaubey03 Great contribution ! 🎉 Your pull request has been successfully merged! Also Take a moment to ⭐ Star the repository if you haven't already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing Several Minor Issues Simultaneously
2 participants