Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 image fixes #193

Merged
merged 1 commit into from
May 12, 2024
Merged

S3 image fixes #193

merged 1 commit into from
May 12, 2024

Conversation

elrido
Copy link
Contributor

@elrido elrido commented May 9, 2024

@elrido
S3 image fixes #192
62bc181 
- only install composer if necessary
- if simplexml is requested, also install it for PHP 8.2, so composer can detect it
- unset composer platform config, it prevented later upgrades of GCP library
- removes unused RAWURL
@elrido elrido requested review from rugk and Zoey2936 May 12, 2024 08:09
@elrido
Copy link
Contributor Author

elrido commented May 12, 2024

Thank you!

@elrido elrido merged commit 605ee7c into master May 12, 2024
14 checks passed
@elrido elrido deleted the s3-composer-fixes branch May 12, 2024 08:56
elrido added a commit that referenced this pull request May 23, 2024
@elrido
Bump alpine from 3.19.1 to 3.20.0
bb09a19 
Also undo now obsolete 8.2 fix for #193, composer now is on the same PHP release as the rest
@elrido elrido mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zoey2936 Zoey2936 Zoey2936 approved these changes

@rugk rugk Awaiting requested review from rugk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting reading response header from upstream error when trying to create new secrets with 1.7.2 on S3
2 participants
@elrido @Zoey2936