Issue 170 #172
Closed
Issue 170 #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { name = "Congyue Cui", email = "[email protected]" } | ||
| ] | ||
| requires-python = ">=3.9" | ||
| # classifiers = [ |
There was a problem hiding this comment.
Are these comments? If yes, could we remove them?
There was a problem hiding this comment.
Yes, we could remove them.
| cmake.define.BUILD_TESTS = "ON" | ||
| cmake.define.ENABLE_SIMD = "ON" | ||
| cmake.define.ENABLE_ATOMICS_BYPASS = "ON" | ||
| # cmake.define.Kokkos_ENABLE_OPENMP = "ON" |
There was a problem hiding this comment.
Should remove this comment as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the changes/features in this pull request.
Issue Number
#170
Checklist
Please make sure to check developer documentation on specfem docs.
[x] I ran the code through pre-commit to check style
[x] My code passes all the integration tests
[x] I have added sufficient unittests to test my changes
[x] I have added/updated documentation for the changes I am proposing
[x] I have updated CMakeLists to ensure my code builds
[x] My code builds across all platforms