Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No macros lite #174

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

No macros lite #174

wants to merge 17 commits into from

Conversation

jonathanschilling
Copy link
Collaborator

This is a first step in removing macros in SPEC.
The source remains to be cleaned up:

  • use -Wunused-variable gfortran option to see unused variables and remove them
  • use fprettify to ensure consistent formatting

@missing-user
Copy link
Contributor

missing-user commented Nov 14, 2024

Hi, is there any progress on this?
Sorry to revive a dead PR, but this kind of refactor would make it easier for somebody new to the codebase (like me) to understand the program and contribute 😇

@jonathanschilling
Copy link
Collaborator Author

Hi, is there any progress on this? Sorry to revive a dead PR, but this kind of refactor would make it easier for somebody new to the codebase (like me) to understand the program and contribute 😇

Not since then - got stuck in certain other projects in the mean time. I would strongly support to continue this. Suggested steps:

  1. keep the setup as-is and adjust the code generators in macros to provide more-or-less readable code - check the auto-generated one
  2. once the auto-generated code looks fine, migrate the generated files to be the main source code files
  3. clean them up locally - remove unused using statements and dead variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants