Suggest better commands when a json adapter is available #346
Conversation
| PS> docker image ls | ||
| ``` | ||
|
|
||
| we can suggest: |
There was a problem hiding this comment.
Need a way to not make the same suggestion multiple times if the user doesn't accept it so it doesn't become noisy. Not sure yet if this should be per feedback provider or part of the feedback subsystem.
There was a problem hiding this comment.
if the accepted suggestion gets in history that can be a way to not repeat the suggestion again and rely on predictors to surface/remind that behavior
| and the `jc` utility is available, we can provide feedback with an improved pipeline: | ||
|
|
||
| ```powershell | ||
| PS> uname -a | jc --uname | ConvertFrom-Json |
There was a problem hiding this comment.
Should also be a predictor so typing uname -a and we know an adapter is available we should predict the whole line
| We can provide the following feedback to the user: | ||
|
|
||
| ```powershell | ||
| docker image ls --format='{{json .}}' | ConvertFrom-Json |
There was a problem hiding this comment.
Should it default to -ashashtable by default or do we think there aren't cases where that matters?
| ### Open Questions | ||
|
|
||
| - How should errors during conversion be handled? | ||
| - In the case where ConvertFrom-Json is used, I would suggest a new parameter for `ConvertFrom-Json` where it simply emits the input string if the conversion fails. |
There was a problem hiding this comment.
Makes sense to me, perhaps with a warning message
| For example, if the user types: | ||
|
|
||
| ```powershell | ||
| PS> docker image ls |
There was a problem hiding this comment.
Need a way that if the command line comes from history, we shouldn't predict/feedback, but this may be part of feedback subsystem
| ``` | ||
|
|
||
| This last suggested pipeline could be generalized to include a suggestion for any `<utility>-json` command if found. | ||
| This may encourage the community to create conversion functions/scripts. |
There was a problem hiding this comment.
Would these <utility>-json be part of PS modules/ are cmdlets? I am just wondering about the customer management of these json adapters
|
|
||
| #### PSDefaultNativeParameterValues | ||
|
|
||
| We can extend the _concept_ of `$PSDefaultParameterValue` to improve the user experience by automatically |
There was a problem hiding this comment.
would it be too complex for the feedback provider to check if there is a default param value on some of its known ones and then not make suggestions? Just wondering about clobbering behaviors
|
|
||
| #### History | ||
|
|
||
| It's not clear whether history should be altered to show the added pipeline elements. |
There was a problem hiding this comment.
This is no longer a problem though with the new feedback provider proposal right?
No description provided.