Implement Webhook cleanup

[bretthoerner]

No description provided.

[bretthoerner]

I got Kafka mocking working and finished up the tests, so this is ready (again).

[tomasfarias]

nit: I may be wrong but I think there is a Serialize/Deserialize implementation for Option and &Option, so we could implement Serialize/Deserialize on ErrorType instead and we would get Serialize/Deserialize on &Option<ErrorType> too. Not a big deal, but would save the check for Some(error_type)/None

[bretthoerner]

Hmmm, maybe I need a special serde annotation to make it work?

error[E0308]: mismatched types
   --> hook-common/src/kafka_messages/app_metrics.rs:46:23
    |
46  | #[derive(Deserialize, Serialize, Debug, PartialEq, Clone)]
    |                       ^^^^^^^^^ expected `ErrorType`, found `&Option<ErrorType>`
...
67  |         serialize_with = "serialize_error_type",
    |                          ---------------------- arguments to this function are incorrect
    |
    = note:   expected enum `ErrorType`
            found reference `&'__a std::option::Option<ErrorType>`
note: function defined here
   --> hook-common/src/kafka_messages/app_metrics.rs:120:4
    |
120 | fn serialize_error_type<S>(error_type: ErrorType, serializer: S) -> Result<S::Ok, S::Error>
    |    ^^^^^^^^^^^^^^^^^^^^    ---------------------
    = note: this error originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info)

[bretthoerner]

I did a little searching but I don't know if this is possible, if you know a way I'm happy to come back and clean it up.

[tomasfarias]

Nice! We may want to re-use this in other tests, so I'm keeping it in mind.

[tomasfarias]

Nice!

[tomasfarias]

Looks pretty good to me, some minor nitty comments here and there that do not necessarily need addressing right now. Thanks!