fix: fixed popover overflowing edge of browser #26464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corywatilo
changed the title
adamleithp
added
bug
thmsobrmlr
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
documented here: #26460
Changes
Added document.body as boundary to popover positioning
Does this work well for both Cloud and self-hosted?
it doesn't have an impact
How did you test this code?
Opened and tested the popover on pages where visible/accessible, tested chrome and firefox/
Screenshots
Broken:
Fixed:
I added some padding and boundary to ensure it flips to other side if near edge!