fix(surveys): Change viewed to Unanswered in survey stats bar #26361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
Phanatic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Survey stats bar uses two similar words to denote two completely different values.
As you can see in the
beforepicture below,ShownandViewedare synonyms but mean different things.Shownis all the times we showed a survey to a user,Viewedis when a customer saw the survey, but didn't dismiss it or fill it out.This is confusing, as we can see. To alleviate this, I'm changing the label on the stacked bar to be
Unansweredwhich matches the intent of the value there.Changes
Before
After
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
👀