Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-warehouse): stop jitter on sync table #26358

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 8 additions & 1 deletion frontend/src/lib/lemon-ui/LemonTable/LemonTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ export interface LemonTableProps<T extends Record<string, any>> {
firstColumnSticky?: boolean
// Max width for the column headers
maxHeaderWidth?: string
/** Whether to hide the scrollbar. */
hideScrollbar?: boolean
}

export function LemonTable<T extends Record<string, any>>({
Expand Down Expand Up @@ -125,6 +127,7 @@ export function LemonTable<T extends Record<string, any>>({
footer,
firstColumnSticky,
maxHeaderWidth,
hideScrollbar,
}: LemonTableProps<T>): JSX.Element {
/** Search param that will be used for storing and syncing sorting */
const currentSortingParam = id ? `${id}_order` : 'order'
Expand Down Expand Up @@ -234,7 +237,11 @@ export function LemonTable<T extends Record<string, any>>({
style={style}
data-attr={dataAttr}
>
<ScrollableShadows direction="horizontal" scrollRef={scrollRef}>
<ScrollableShadows
innerClassName={hideScrollbar ? 'hide-scrollbar' : undefined}
direction="horizontal"
scrollRef={scrollRef}
>
<div className="LemonTable__content">
<table>
<colgroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export const Syncs = ({ id }: SyncsProps): JSX.Element => {

return (
<LemonTable
hideScrollbar
dataSource={jobs}
loading={jobsLoading}
disableTableWhileLoading={false}
Expand Down
Loading