Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mobile unusable warnings #26352

Merged
merged 4 commits into from
Nov 24, 2024
Merged

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Nov 22, 2024

Problem

Replaces https://github.com/PostHog/posthog/pull/26147/files
#26147 (comment)

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@marandaneto marandaneto requested a review from a team November 22, 2024 10:26
@marandaneto marandaneto enabled auto-merge (squash) November 22, 2024 10:26
Copy link
Contributor

github-actions bot commented Nov 22, 2024

Size Change: 0 B

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.16 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marandaneto marandaneto merged commit a7a9721 into master Nov 24, 2024
96 checks passed
@marandaneto marandaneto deleted the fix/mobile-unusable-warning-2 branch November 24, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants