fix: use combinations in the breakdowns test for perf #26325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspicer
reviewed
Nov 21, 2024
| @@ -3844,7 +3844,7 @@ def test_trends_event_multiple_breakdowns_combined_types(self): | |||
| Breakdown(type="group", group_type_index=0, property="industry"), | |||
| ] | |||
|
|
|||
| for breakdown_filter in itertools.permutations(breakdowns, 2): | |||
| for breakdown_filter in itertools.combinations(breakdowns, 3): | |||
There was a problem hiding this comment.
should we do combinations 2 instead of combinations 3?
this will halve it again, correct? from 56 to 28.
There was a problem hiding this comment.
Initially, I thought keeping three combinations would be safer for a regression test. I couldn’t find a good reason to do so now, so I changed it to two.
aspicer
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Only combinations of elements matter in the test. The original test has 336 iterations, while with combinations this count is reduced to 56 still using three elements.
Changes
Use combinations instead of permutations, as permutations are unnecessary.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
N/A