Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(err): show a list of symbol sets and associated frames #26300

Closed
wants to merge 7 commits into from

Conversation

oliverb123
Copy link
Contributor

@oliverb123 oliverb123 commented Nov 19, 2024

Started sketching this out a bit - still not totally sure what I'm doing, and relying heavily on asking LLMs what stuff is, but it seems basically reasonable and at least the curls I'm using to test the backend part work well.

TODO: wire up these api extensions to actually be used somewhere, see if they work

Oh this also turns cymbal on for all teams, because I needed to make the edit while doing e2e local testing, and I think we're at the point where it makes sense to do in prod.

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Size Change: +425 B (+0.04%)

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.16 MB +425 B (+0.04%)

compressed-size-action

@oliverb123
Copy link
Contributor Author

oliverb123 commented Nov 20, 2024

Current state (just dumped the component in a place I knew where to find):

2024-11-20 11 55 48

BRB adding "full stack engineer" to my linkedin

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

10 snapshot changes in total. 0 added, 10 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@daibhin
Copy link
Contributor

daibhin commented Nov 21, 2024

This was super helpful. Took all the necessary changes in #26331

@daibhin daibhin closed this Nov 21, 2024
@daibhin daibhin deleted the olly_err_symbol_set_ui branch November 21, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants