feat(experiments): Support for data warehouse experiments #26247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
danielbachhuber
commented
Nov 19, 2024
| return BreakdownFilter( | ||
| breakdown=self.breakdown_key, | ||
| breakdown_type="event", | ||
| ) | ||
|
|
||
| def _get_data_warehouse_breakdown_filter(self, column_name: str) -> BreakdownFilter: | ||
| return BreakdownFilter( | ||
| breakdown=f"{column_name}.properties.`{self.breakdown_key}`", |
There was a problem hiding this comment.
@jurajmajerik As it turns out, this syntax isn't supported yet. See some conversation here: https://posthog.slack.com/archives/C019RAX2XBN/p1732050126051829
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Messy rebase, starting afresh #26356 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #26332
Changes
TBD
Still to do:
$feature_flag_calledevent (the most recent)$feature_flag_calledevent has already been calledHow did you test this code?
TBD