-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add frameworks to onboarding part 3 #21158
Merged
Lior539
merged 7 commits into
add-frameworks-to-onboarding-part-2
from
add-frameworks-to-onboarding-part-3
Apr 2, 2024
Merged
feat: Add frameworks to onboarding part 3 #21158
Lior539
merged 7 commits into
add-frameworks-to-onboarding-part-2
from
add-frameworks-to-onboarding-part-3
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Size Change: 0 B Total Size: 821 kB ℹ️ View Unchanged
|
raquelmsmith
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ 🙌
I'm assuming you'll get a merge conflict with this and #21091
Lior539
force-pushed
the
add-frameworks-to-onboarding-part-3
branch
from
April 2, 2024 12:36
9fe89c5
to
9f04fbd
Compare
Lior539
merged commit Apr 2, 2024
e27dbe1
into
add-frameworks-to-onboarding-part-2
12 of 16 checks passed
Lior539
added a commit
that referenced
this pull request
Apr 2, 2024
* astro * add bubble * framer * laravel * nuxt * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * add remix * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update frontend/src/scenes/onboarding/sdks/feature-flags/angular.tsx * feat: Add frameworks to onboarding part 3 (#21158) * svelte * missing export * export * webflow * vue * django * flag code --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Raquel Smith <[email protected]>
Lior539
added a commit
that referenced
this pull request
Apr 2, 2024
* astro * add bubble * framer * laravel * nuxt * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * add remix * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (2) * Update UI snapshots for `chromium` (2) * Update frontend/src/scenes/onboarding/sdks/feature-flags/angular.tsx * feat: Add frameworks to onboarding part 3 (#21158) * svelte * missing export * export * webflow * vue * django * flag code --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Raquel Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more frameworks to onboarding: