Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix single property materialization command #20798

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Mar 8, 2024

Problem

Running a management command to materialize a single property didn't work. Also, default to not backfilling unless specified.

Changes

now it does

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

Copy link

sentry-io bot commented Mar 8, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: ee/management/commands/materialize_columns.py

Function Unhandled Issue
handle ValueError: too many values to unpack (expected 3) ee.clickhouse.materialized_columns.analyze in materialize_properties_ta...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Contributor

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

@timgl timgl reopened this Mar 27, 2024
@posthog-bot posthog-bot removed the stale label Mar 28, 2024
@timgl timgl merged commit 68181ad into master Mar 28, 2024
200 of 202 checks passed
@timgl timgl deleted the fix-single-property-materialization branch March 28, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants