Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for finite fields #12

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Commits on Oct 24, 2022

  1. Configuration menu
    Copy the full SHA
    4ecac9e View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. intermediate check-in after some more testing

    Code somehow runs but is not clean
    
    * how to handle pivoting is clear, LinearAlgebra of 1.9 provides RowNonZero() pivoting and lupivottype(T)
    strategy, this needs to be used on 1.9, we need to define our own for <1.9
    
    * As in the test example for LinearAlgebra, we need to define
      lupivottype, abs and isless for finite fields. See
      https://github.com/JuliaLang/julia/blob/1471cd9782aad18f54d8cb04316193ada15e37bd/stdlib/LinearAlgebra/test/generic.jl#L470
      Otherwise the code does not compile. May be one can avoid this by modularizing LU.
    
    * The BIGGY problem is more serious: it occurs that BIGGY is used as an undefined marker of unititialized matrix entries.
      It is not to be expected that finite fields will have some "unitialized" value.
      Getting rid of this would need a rewrite of the input methods. This IMHO would improve the API - push! is very efficient,
      so we can rely on this, no need to estimate nnz  before.
    j-fu committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    42d3bd3 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Configuration menu
    Copy the full SHA
    02192ae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    850db55 View commit details
    Browse the repository at this point in the history