Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional endpoints. #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mitchellkellett
Copy link

Added additional endpoints for city, longitude, latitude, accuracy radius, and timezone.

Updated README to reflect these as well.

Mitchell Kellett added 3 commits March 10, 2023 22:49
…INX maps.

	- New map.conf that containing maps.
	- Updated nginx.conf to increase map_hash_bucket_size above default value.
	- Updated geoip2.conf to include new variables for lookup IP addresses.
	- Updated ipinfo.conf to include new location blocks to allow for looking up IP addresses.
Moved existing functionality for looking up requesting IP address to use NGINX maps.
	- Updated ipinfo.conf to remove old location blocks that have been moved to map.conf.
Updated README to include details on added functionality.
Added build data to headers.
Formatting updated throughout.
Updated regex to fix identified bug in map.conf.
Copy link
Owner

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this duplicated with #23?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 6 changed files in this pull request and generated no suggestions.

Files not reviewed (5)
  • Dockerfile: Language not supported
  • nginx/conf.d/geoip2.conf: Language not supported
  • nginx/conf.d/ipinfo.conf: Language not supported
  • nginx/conf.d/map.conf: Language not supported
  • nginx/nginx.conf: Language not supported
Comments skipped due to low confidence (1)

README.md:101

  • [nitpick] The term 'accuracy radius' is ambiguous. Consider renaming it to 'geo_accuracy' for better clarity.
- `accuracy_radius`: Longitude & Latitude accuracy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants