-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to publish image on GitHub Container Registry #12
base: master
Are you sure you want to change the base?
Conversation
@PeterDaveHello please review this PR ^ |
@Cubxity cool, I'll take a look, thanks! |
push: | ||
branches: [ "master" ] | ||
schedule: | ||
- cron: 0 0 * * * # Every day |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every weekend would be good enough I think, the upstream doesn't update so frequently.
platforms: linux/amd64,linux/arm64 | ||
tags: ghcr.io/${{ steps.vars.outputs.repository }}:latest | ||
build-args: | | ||
MAXMIND_LICENSE_KEY=${{ secrets.MAXMIND_LICENSE_KEY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the missing newline char at the last line, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cubxity thanks for your contribution, as I'm already using Travis CI here, I wonder maybe it's easier to maintain only one workflow tool, can you integrate the flow here to .travis.yml
? Thank you.
@Cubxity not sure if you'd like to continue contribute to this PR? I'll like to get it merged ;) |
Will you continue, @Cubxity? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Added a workflow to publish image on GitHub Container Registry on push to master and on a daily schedule. This requires the secret
MAXMIND_LICENSE_KEY
to be set in the repository.Resolves #7