Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to publish image on GitHub Container Registry #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Cubxity
Copy link

@Cubxity Cubxity commented Oct 2, 2021

Added a workflow to publish image on GitHub Container Registry on push to master and on a daily schedule. This requires the secret MAXMIND_LICENSE_KEY to be set in the repository.

Resolves #7

@Cubxity
Copy link
Author

Cubxity commented Oct 7, 2021

@PeterDaveHello please review this PR ^

@PeterDaveHello
Copy link
Owner

@Cubxity cool, I'll take a look, thanks!

push:
branches: [ "master" ]
schedule:
- cron: 0 0 * * * # Every day
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every weekend would be good enough I think, the upstream doesn't update so frequently.

@PeterDaveHello PeterDaveHello changed the title Added workflow to publish image on GitHub Container Registry Add workflow to publish image on GitHub Container Registry Oct 15, 2021
platforms: linux/amd64,linux/arm64
tags: ghcr.io/${{ steps.vars.outputs.repository }}:latest
build-args: |
MAXMIND_LICENSE_KEY=${{ secrets.MAXMIND_LICENSE_KEY }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the missing newline char at the last line, thanks.

Copy link
Owner

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cubxity thanks for your contribution, as I'm already using Travis CI here, I wonder maybe it's easier to maintain only one workflow tool, can you integrate the flow here to .travis.yml? Thank you.

@PeterDaveHello
Copy link
Owner

@Cubxity not sure if you'd like to continue contribute to this PR? I'll like to get it merged ;)

@MartinHennrich
Copy link

Will you continue, @Cubxity?
This looks really promising. 👍

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish image on GitHub Packages
3 participants