Fix some perl-in-space problems #416
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohawk2
force-pushed
the
autoconf-space
branch
from
7445816
to
30aed66
Compare
|
(I've fixed the CI which was making a somewhat false negative from detecting error output which was generated by a locale error) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at PDLPorters/pdl#498 I wanted to update Alien::proj on my Windows "in space" setup to try to reproduce the problem. The
autoconfstuff in Alien::sqlite failed. This is a partial fix for that.This quote-protects the prefix path (where Perl is installed) so
configuredoesn't get the wrong args. It also adds--disable-dependency-trackingwhich seems like it will always be fine, and prevented the next failure, which was in makefile fragments inclusion. The failure after that seems to be because theautoconfstuff is getting various compiler components that have spaces in their paths, and putting newlines instead of the spaces. I couldn't find whereconfigurewas doing that, and have figured out a more idiomatic way to test Proj in any case, so I thought a material improvement was better than nothing.