Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect variable init in showdiff header comparison #269

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix incorrect variable init in showdiff header comparison #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion perun/utils/common/diff_kit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ def generate_diff_of_headers(
# Check if we should include all entries or just the diff ones
display_style = HeaderDisplayStyle(config.lookup_key_recursively("showdiff.display_style"))
only_diff = display_style == HeaderDisplayStyle.DIFF
is_diff: bool = False
for header_key in sorted(header_map.keys()):
is_diff: bool = False
lhs_data, rhs_data = _generate_missing_entry(*header_map[header_key])
if lhs_data.details or rhs_data.details:
# There are details in this entry, compare them one by one
Expand Down
Loading