Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 4 machine learning books #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added 4 machine learning books #16

wants to merge 2 commits into from

Conversation

Kapilshanbhag09
Copy link

No description provided.

@Parasgupta44
Copy link
Owner

Hi @Kapilshanbhag09 . Thanks for contributing.

  • You have added Books as a standalone React component (?)
  • Do you want to include it somewhere to display on the page ?

@Kapilshanbhag09
Copy link
Author

Hi @Parasgupta44
I had started react js 15 days back and I contributed from whatever I knew. Becuase of which I am not much sure about the React Component. Sorry for that thing.

Its ok if the books lists are at the bottom as your choice.

@Parasgupta44
Copy link
Owner

@Kapilshanbhag09 No need to say sorry at all. Everyone's learning here only.
One thing you can do is just add those list of books (that you added in ml_books.json) to ml_resources.json in the format given and maybe remove Books.js and Books.css files.
You can then generate a new PR with that new commit I can merge it to the master for deploying it.

@Kapilshanbhag09
Copy link
Author

Oh, Ok I will do that

@Kapilshanbhag09
Copy link
Author

I have done it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kapilshanbhag09 @Parasgupta44