feat(transactional-adapter-mikro-orm): add mikro orm adapter #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Papooch
reviewed
Nov 18, 2024
There was a problem hiding this comment.
Thank you for the PR.
I only left minor nitpicks, but I also just noticed that MikroORM also comes with its own @Transactional decorator, so the adapter might not be needed after all (unless there's some use case, in which the built-in support is inferior).
| }, | ||
| "peerDependencies": { | ||
| "@mikro-orm/core": "^6.4.0", | ||
| "@mikro-orm/postgresql": "^6.4.0", |
There was a problem hiding this comment.
I don't think the postgres driver needs to be in peer dependencies, it is only used dot tests.
| /** | ||
| * The injection token for the MikroORM instance. | ||
| */ | ||
| dataSourceToken: any; |
There was a problem hiding this comment.
This option should be called something like mikroOrmInstance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#164