Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update transforms.conf #256

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update transforms.conf #256

wants to merge 2 commits into from

Conversation

as3923
Copy link
Contributor

@as3923 as3923 commented May 9, 2022

Description

Resolve issue #101

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@hinchliff
Copy link

I don't believe this PR is correct. I think src_user needs to be added, in between the existing src_ip and source_name. (source_name should not be removed)

@as3923
Copy link
Contributor Author

as3923 commented May 26, 2022

You're right. I misread the documentation. I've updated it again.

@paulmnguyen paulmnguyen force-pushed the develop branch 2 times, most recently from de4dfdc to d7bd687 Compare May 17, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@as3923 @hinchliff