Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix helipr #10

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Fix helipr #10

merged 3 commits into from
Mar 26, 2024

Conversation

benemer
Copy link
Member

@benemer benemer commented Mar 26, 2024

This PR fixes some issues with the helipr dataloader:

  • The previous .find() returns -1 if the string is not found, which was always the case because the folder names are capitalized and not lowercase, see image below. Therefore, the dtype for Avia was always used no matter which sensor was selected
  • import matplotlib.cm as cm was missing
  • There is a weird special case for specific Aeva sequences for which apparently no intensity is recorded. See here
  • Some types were incorrect (shouldn't matter much, though)

image

@benemer
Copy link
Member Author

benemer commented Mar 26, 2024 •
edited
Loading

  • Fixed normalization of intensity for Aeva, because this has negative values 🤷

@benemer benemer requested a review from nachovizzo March 26, 2024 14:12
@nachovizzo nachovizzo merged commit 5f5bc16 into main Mar 26, 2024
6 checks passed
@nachovizzo nachovizzo deleted the benedikt/fix_helipr branch April 3, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saurabh1002 saurabh1002 Awaiting requested review from saurabh1002

@nachovizzo nachovizzo Awaiting requested review from nachovizzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benemer @nachovizzo