Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/37 kuzya installer script #38

Open
wants to merge 24 commits into
base: development
Choose a base branch
from

Conversation

alexchmykhalo
Copy link
Collaborator

No description provided.

Alex Chmykhalo and others added 22 commits January 22, 2017 22:32
Qt libs deploying. Used 7z for unpacking MSYS2. Removed updating MSYS2.
Copy link
Contributor

@BaranovMykola BaranovMykola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some conflicts with appveyor.yml - Olya updated appveyor to Qt5.8

cd %APPVEYOR_BUILD_FOLDER%\src


python generate.py -v 2.1.12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it only generate version 2.1.12?

build:
verbosity: minimal

artifacts:
- path: tools\kuzya-2.1.12-win64-full.exe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we should use name in format "kuzya-VERISON-win64-full.exe What will be if there are another version? Will name be changed?

;Name and file
Name "kuzya 2.1.12"
Caption "kuzya 2.1.12 - Free IDE for Education"
OutFile "kuzya-2.1.12-win64-full.exe"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm worried about dynamic version again...

Copy link
Contributor

@grafit7 grafit7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did a great job, but I think you should add comments in some files because not everyone understands what you're doing:)

appveyor.yml Outdated
@@ -4,23 +4,47 @@ pull_requests:
environment:
priv_key: MIIEpQIBAAKCAQEAv4fBo1XxZHg495pz+so9he1zutEAS+ah3/rt83OQYgJggRoH l5lVnYsoVkfu5l53RtaIO4Qb62Vv7G1qh91xGwv5KqI/q2iHT+kdtBEBIPQADJzA 4hnseeaqadHndwP44KjiAu/mxeU+9iwv3Cosa4f6wmD1A6/5xqLu0C4vOqc71bze 0oZzMLPlTxP/9XQdXxKkbGzjniQd8QQuCtjdXGm3UPtah9/CmWPp05V0Z0as2ezh 2xlMvy0RH0UuuIRbiyWi1Y0HP7zfCs0GyhBvAhhkKSX7pZNKwu/Q5se14/aiteoP X/WXnmeXlSzZgd5EpxWS4ADkkPKa2jnBgkA/sQIDAQABAoIBAHZ/ZINMseuqIfy3 F5iLNaM9tQNZOai8CVzNIBkmX6bzt4dIdngJyxmMtikjmh/3RC6UnnbMFoX+HVAW pflnPQoxzzfcaC4Bnu4G2XTFrIAZ1kn3VbLNvSvyVW7hCibtUzaT5jlQ+eNoIRsn XXkGsrLYz4EhgZWFc7C8r6onWNsc+G8WBshUUowIVkcc5MFB3qP8M6MznFtq2gmn YV+DTTtsRCLIrlhi90CFXd5CHpGTNjolX/8a72iEYNOUQmzTTOz7EzprkZsCv1Ag hOayoVoTCrOBOZtNTTnRt/g2+/EAHPT+kyN6EdxKerfrgeG5tENBK9GzJthIa1eM Gavq9gECgYEA4fpmdcW9FdS1pGYlo1zo7+y7pCbBttVv7Lp30bUaXic5sIMV4/MI qeT5jH/iZ2duGdJotjB0MMwYXS0KHP+5Uf+JvbTSDEL+3ffzZ9kPhbZ7CYsQ91/R lrp6jzHygUwMR3q2XFzXgp2meluwNm97TM80l0chysnmicSmYmA3U5ECgYEA2PnF 1ayahkAtCSuIZzok6NSoPCk2H1ktlQXFyiFS6EzmCIPU+jiGtpf8y3o5t0ffpZoV iQ/Amhf3dLPZ6iJ5D/IUZW/vwZLQ0R2o/izhA66ZBjNOUZrtsyeY7IKgfEKHdzzs FsFL2P7iJA9Kjuxn/m9cGUWtM00IspaCrUol2iECgYEAlem9EUJ2F0Z+niqZq4+W hJxjOxnvBvD/iGeH15oyfOW+0seTvR5c0AC0QK4SL5EhLIY2qy7n1ft/6khX3jcT 5T8GTNDpS/MiC3VTh8ArGQSfCQy127Y4X6skZVy4SWh++OiClDGPUvptF909wE8i 2CjZ9cXduB9LDnhj/P1hltECgYEAhkDuV4soRd9Zvm3QRcclZWeH/Ummsnj0ilv7 CVnbOd+zChvAYV8ug7bBdYnYQn7XdFlF7/vuOaqQtAZA1O2lqOcqFaXQXR8h0/Kd SUCtriCPkNWYJUhOwebDabxd3uUveukYT/AkpUz40kUf5hWDN1ziSMTjKXYF5rLY gq75guECgYEAqjMLd+wBtDuZUqVi7Fcukje/ORpzPWspLf3UiTJ+vVaZXJC93y/s NtiRcbhB2njDcg2MbPI9hva7PD/JaSxEC9H6oOKizCazI4hwr94tFLQ9LITI8Szb kokSNRQ8foc+hOuNcvOdU3kXDuUR5CGgHS1C/F/f2jOw1DYwsfcgCFY=
QT_INSTALL_ROOT: C:\Qt\5.7\msvc2015_64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in current the line, you have a conflict with development branch coz we use 5.8 Qt

OutFile "kuzya-2.1.12-win64-full.exe"

;Default installation folder
InstallDir "c:\kuzya"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it isn't good idea install Kuzya in a root of system. Maybe better install in C:\Program Files?

;LangString DESC_SecMinGW ${LANG_UKRAINIAN} "���������� MinGW"
;LangString DESC_SecMinGW ${LANG_BELARUSIAN} "���������� MinGW"
;LangString DESC_SecMinGW ${LANG_FRENCH} "Installer MinGW"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you left here this comments?

echo Setting up environment...
set KUZYA_BUILD_ROOT=c:\projects\kuzya
set KUZYA_MSYS64_ROOT=c:\msys64
set KUZYA_QSCINTILLA_VERSION=2.9.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now we use the new version QScintilla, fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants