chore: better tests

.github/workflows/ci.yaml

@@ -246,16 +246,6 @@ jobs:
         with:
           path: coverage/lcov.info
           min_coverage: 90 # 100
-          exclude: >-
-            lib/src/gen/*.gen.dart
-            lib/src/features/**/*.g.dart
-            lib/src/features/**/*.freezed.dart
-            lib/src/utils/*.g.dart
-            lib/src/utils/*.freezed.dart
-            lib/src/app/*.gr.dart
-            lib/src/app/*.gm.dart
-            lib/src/l10n/app_localizations.dart
-            lib/src/l10n/app_localizations_*.dart
 
   format:
     name: Formatting

lib/main.dart

@@ -1,11 +1,11 @@
+import 'package:flutter/widgets.dart';
 import 'package:shared_preferences/shared_preferences.dart';
 
 import 'src/app/app.dart';
-import 'src/app/bootstrap.dart';
 
 Future<void> main() async {
   await const MyApp().bootstrap(
-    const RunApp(),
+    runApp,
     SharedPreferences.getInstance,
   );
 }

lib/src/app/bootstrap.dart

@@ -1,5 +1,5 @@
+// ignore_for_file: scoped_providers_should_specify_dependencies
 import 'package:flutter/services.dart';
-import 'package:flutter/widgets.dart' as flutter;
 import 'package:flutter/widgets.dart';
 import 'package:flutter_web_plugins/url_strategy.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';
@@ -17,9 +17,9 @@ mixin Bootstrap on Widget {
   /// - calling [usePathUrlStrategy] to use path-style URLs,
   /// - setting up the [SettingsService] and loading the user's preferences,
   /// - initializing riverpod's [ProviderScope], and
-  /// - running the app with [RunApp].
+  /// - running the app with [runApp].
   Future<void> bootstrap(
-    RunApp runApp,
+    void Function(Widget app) runApp,
     Future<SharedPreferences> Function() getSharedPreferences,
   ) async {
     // Don't use hash style routes.
@@ -37,34 +37,15 @@ mixin Bootstrap on Widget {
     final initialSettings = await loadSettings(prefs);
 
     // Run the app.
-    runApp.runApp(
-      this,
-      overrides: [
-        sharedPreferencesProvider.overrideWithValue(prefs),
-        initialSettingsProvider.overrideWithValue(initialSettings),
-      ],
-    );
-  }
-}
-
-/// {@template RunApp}
-/// Allow mocking runApp in tests.
-/// {@endtemplate}
-class RunApp {
-  /// {@macro RunApp}
-  const RunApp();
-
-  /// See [flutter.runApp]
-  void runApp(
-    Widget app, {
-    List<Override> overrides = const [],
-  }) {
-    flutter.runApp(
+    runApp(
       ProviderScope(
-        overrides: overrides,
+        overrides: [
+          sharedPreferencesProvider.overrideWithValue(prefs),
+          initialSettingsProvider.overrideWithValue(initialSettings),
+        ],
         child: RestorationScope(
           restorationId: 'root',
-          child: app,
+          child: this,
         ),
       ),
     );

test/helpers/mocks.dart

@@ -1,7 +1,4 @@
-import 'package:duly_noted/src/app/bootstrap.dart';
 import 'package:mocktail/mocktail.dart';
 import 'package:shared_preferences/shared_preferences.dart';
 
 class MockSharedPreferences extends Mock implements SharedPreferences {}
-
-class MockRunApp extends Mock implements RunApp {}

test/src/app/bootstrap_test.dart

@@ -16,19 +16,14 @@ void main() {
   });
 
   test('main does not throw', () async {
-    final mockRunApp = MockRunApp();
     const app = MyApp();
 
     await expectLater(
       app.bootstrap(
-        mockRunApp,
+        (_) {},
         getSharedPreferences,
       ),
       completes,
     );
-
-    // Verify that runApp was called with an instance of MyApp.
-    verify(() => mockRunApp.runApp(app, overrides: any(named: 'overrides')))
-        .called(1);
   });
 }

test/src/features/settings/application/settings_service_test.dart

@@ -33,17 +33,17 @@ void main() {
     });
   });
 
-  group('initialPreferences', () {
-    test('should throw an error if initialPreferences is not provided', () {
+  group('initialSettings', () {
+    test('should throw an error if initialSettings are not provided', () {
       // Arrange
       final container = ProviderContainer();
 
-      // Act
-      PreferencesRepository call() =>
-          container.read(preferencesRepositoryProvider);
-
       // Assert
-      expect(call, throwsA(isA<UnimplementedError>()));
+      expect(
+        // Act
+        () => container.read(initialSettingsProvider),
+        throwsA(isA<UnimplementedError>()),
+      );
     });
   });
 }