Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

202-feature-upgrade-all-dependencies #208

Open
wants to merge 25 commits into
base: dev
Choose a base branch
from

Conversation

tombeckenham
Copy link
Collaborator

No description provided.

@tombeckenham tombeckenham marked this pull request as ready for review November 25, 2024 02:54
Copy link
Collaborator Author

@tombeckenham tombeckenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a tonne of changes in this code. I have upgraded to React 18, and updated most libraries to compatible versions. To upgrade react, several things needed to be altered - namely the animations which used incompatible libaries. Most of the changes made to the codebase are automated. I had to remove all of the Themeproviders which were wrongly included in components.

The main things to look for are the useEffect dependency updates. If any useEffect has a dependency that is a function that has been passed in as a paramater or returned from something else, that function must have been wrapped in a useCallback or useMemo.

The other thing to look are the setUserWallet functions which was trying to update local or static variables and should have been using state instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants