Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AES decryption to #sign #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

djwillcaine
Copy link

Added a passphrase input to #sign which allows you to enter an AES-256
encrypted key into the private key input if you chose, which will be
decrypted using the passphrase.

Added a passphrase input to #sign which allows you to enter an AES-256
encrypted key into the private key input if you chose, which will be
decrypted using the passphrase.
@dabura667
Copy link
Contributor

BIP38 support seems logical, but AES-256 is not a standard anywhere.

NACK

@djwillcaine
Copy link
Author

Just to clarify the reasoning for this was because the new address page has the option to AES encrypt your private key already, however there is no where available to decrypt this without using third party software.

As long as AES-256 encryption is offered on the new address page the way it currently is, I personally see a purpose for this.

Perhaps an alternative would be to replace the AES encryption altogether. Personally I just added this in for my own ease of use.

@dabura667
Copy link
Contributor

In that case, the trigger should not be just the value of the password box.

Ideally there should be a checkbox that onclicks to show() the entry input, unchecking hide() it as well as sets the val('') and empties it.

The form should decide whether to attempt decryption by the checkbox, not the value of the password

You should also give the input the same restrictions (if any) as the encryption input. A lot of users remember their passwords based on the requirements given to them.

@djwillcaine
Copy link
Author

Firstly, yes there are multiple ways of deciding whether to use encryption but I wanted to make it as simple as possible. I would argue is quicker and easier for the user to either type or not type a password.

One solution I thought of but did not implement, however could easily be done, is to hide the password box and show it if the input of the private key box apears to be encrypted. This would be even more simple and obvious to the user.

With respect to the restrictions, there are none and so there is nothing to display that would be helpful in this case.

@CryptoFM91
Copy link

Hi,
Please can you tell me how to extract a WIF or private key from an AES-256 Encrypted WIF key ?
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants